fix: guard getItem against null/empty data and out-of-range index#18
Open
shawerestart wants to merge 7 commits into
Open
fix: guard getItem against null/empty data and out-of-range index#18shawerestart wants to merge 7 commits into
shawerestart wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens data access in the Android native K-line chart module by making
getItem(int position)null-safe and index-safe inBaseKLineChartView.The change prevents runtime crashes when chart data is empty, not initialized, or when an out-of-range index is requested during rendering/interaction.
Scope
Only the following file is included in this PR scope:
src/native-modules/native-kline-view/android/src/main/java/com/github/fujianlian/klinechart/BaseKLineChartView.javaProblem
Previously,
getItem(int position)directly returned:configManager.modelArray.get(position)This could fail in common edge cases:
modelArrayisnull(data not ready yet)modelArrayis emptypositionis out of bounds (negative or larger than last index)Any of the above could trigger exceptions and cause chart instability/crashes.
What Changed
getItem(int position)now:size = (modelArray == null) ? 0 : modelArray.size()KLineEntitywithDate = ""whensize <= 0safeIndex = Math.max(0, Math.min(position, size - 1))modelArray.get(safeIndex)Why This Approach
Expected Impact
Risk Assessment
Low risk:
modelArraypresent + valid index) remains effectively unchanged.Test Plan
Manual verification
Edge-case verification
modelArray = nulland confirm method returns fallback entity.< 0and> size-1, confirm clamping works and no exception occurs.