Add session acknowledgement API + dependency upgrades#40
Open
rockwellll wants to merge 1 commit intomainfrom
Open
Add session acknowledgement API + dependency upgrades#40rockwellll wants to merge 1 commit intomainfrom
rockwellll wants to merge 1 commit intomainfrom
Conversation
1a5ff23 to
1b2db51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcksAPIclass (src/api/acks.js) that POSTs topublic/ackswith the current session and timestamp. The session setter now callsAPI.acks.send()on first set and whenever the session changes (identity change), usinghello_session_ack_atas a guard to avoid duplicate acks. Business is now assigned first inHellotext.initialize()so the ack has a valid auth context when fired during session initialization.Note
Medium Risk
Adds a new network call triggered from the
Session.sessionsetter and changes cookie-based session side effects; incorrect conditions could cause extra requests or missed acknowledgements.Overview
Adds a new
AcksAPI(API.acks.send) that POSTs{session, at}topublic/acksusingHellotext.headers.Updates the
Session.sessionsetter to automatically send an ack on first set and whenever the session value changes, using ahello_session_ack_atcookie to suppress duplicate acks and resetting that cookie on identity changes. Test coverage is expanded insession_test.jsto validate ack sending and cookie behavior.Written by Cursor Bugbot for commit 1b2db51. This will update automatically on new commits. Configure here.