Improvements#46
Merged
Merged
Conversation
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-07-26 |
…d initializeCommand The feature had neither mounts nor postStartCommand — setup-credentials.sh was generated at build time but never executed, so credential persistence never actually worked. Added the missing mounts + postStartCommand (same shape as claude-dev). A Feature-level initializeCommand does not work (silently ignored by the devcontainers CLI), so the required 'mkdir -p ~/.vibe' is documented as a consumer-side devcontainer.json addition in the README instead, matching claude-dev's existing pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…nt sources Docker file bind-mounts fail hard if the host source doesn't exist — previously only documented for the opt-in AWS/kube/Docker mounts, but the same risk applies to the mandatory ones (~/.npmrc and ~/.yarnrc.yml in particular are frequently absent on a fresh machine). Added a comprehensive initializeCommand to the README's Usage section covering every bind-mount source, mandatory and opt-in. No change to sync-files.sh behavior. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…d before version Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…h dotfiles-sync installsAfter pointed at ghcr.io/helpers4/devcontainer/local-mounts, which no longer resolves — the feature was renamed to dotfiles-sync. Harmless (installsAfter silently ignores unresolvable ids) but misleading. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Scaffolds a new DevContainer Feature end to end (manifest, install.sh, README, test), mirroring helpers4/typescript's /add-helper skill. Bakes in the mounts/initializeCommand constraints and JSON-only-manifest rule from AGENTS.md so new features don't repeat the mistral-dev/dotfiles-sync mistakes just fixed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Corrects the AGENTS.md mount guidance with the verified mechanism (Feature-level initializeCommand is silently ignored by the devcontainers CLI — only the consumer's devcontainer.json is honored) and checks off the resolved TODO items, including two findings that changed conclusion under closer inspection (claude-dev's initializeCommand removal was correct, not a regression; dotfiles-sync's username handling isn't actually worse than claude-dev/mistral-dev's). Logs one new follow-up: claude-dev/mistral-dev's username option is dead code, not wired into their install.sh. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.