Fix/username option not wired#47
Merged
Merged
Conversation
The 'username' option was declared in devcontainer-feature.json and documented in the README, but install.sh never read _BUILD_ARG_USERNAME — h4_detect_user ran its own vscode/node/codespace/uid-1000 auto-detection regardless of what a consumer explicitly set. Default changed from 'node' to 'auto' so the existing auto-detect behavior is preserved when the option is left alone, while an explicit override now actually takes effect. Verified both paths locally (default still resolves via auto-detect; explicit override wins; invalid username still falls back to root). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same dead-option bug as claude-dev: install.sh never read _BUILD_ARG_USERNAME. Same fix — default changed from 'node' to 'auto' to preserve current auto-detect behavior, explicit override now works. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Every item in TODO.md is now resolved (the last one — claude-dev/mistral-dev's dead username option — fixed in the two preceding commits), so the plan file has served its purpose. Design constraints it referenced remain in AGENTS.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-07-26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.