Remove duplicate TYPE_CHECKING imports in FAB auth manager roles.py#2
Closed
Copilot wants to merge 4 commits intocommon-routerfrom
Closed
Remove duplicate TYPE_CHECKING imports in FAB auth manager roles.py#2Copilot wants to merge 4 commits intocommon-routerfrom
Copilot wants to merge 4 commits intocommon-routerfrom
Conversation
1 task
Copilot
AI
changed the title
[WIP] Centralize FastAPI auth manager routing
fab: centralize FastAPI auth manager routing
Feb 10, 2026
Copilot stopped work on behalf of
henry3260 due to an error
February 10, 2026 11:09
Co-authored-by: henry3260 <108824346+henry3260@users.noreply.github.com>
Co-authored-by: henry3260 <108824346+henry3260@users.noreply.github.com>
Copilot
AI
changed the title
fab: centralize FastAPI auth manager routing
Remove duplicate TYPE_CHECKING imports in FAB auth manager roles.py
Feb 10, 2026
henry3260
pushed a commit
that referenced
this pull request
Feb 11, 2026
) (apache#60734) * dag_processing: initialize versioned bundles for callbacks (apache#52040) * Apply suggestion from @amoghrajesh Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Apply suggestion from @amoghrajesh Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Apply suggestion from @amoghrajesh Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Add unit tests for callback handling and improve logging in Dag processing * fix CI static checks #2 --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
henry3260
force-pushed
the
common-router
branch
5 times, most recently
from
fcfd02b to
a6c5167
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoleBodyandRoleResponsewere imported twice inroles.py- once in the regular imports block and again underTYPE_CHECKING, causing redundant code.Changes:
TYPE_CHECKINGblock containing duplicate imports ofRoleBodyandRoleResponsedatamodels.roleswhich are sufficient for both runtime and type checkingThe types are used directly in function signatures at runtime, so conditional imports under
TYPE_CHECKINGwere unnecessary.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.