feat: skip caching token in keychain mode for accounts cache#3792
Open
k80bowman wants to merge 7 commits into
Open
feat: skip caching token in keychain mode for accounts cache#3792k80bowman wants to merge 7 commits into
k80bowman wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds keychain-mode awareness to the accounts cache system to prevent token persistence to disk when keychain storage is active.
When
credentialStore(keychain) is configured, the CLI now:accounts:addcommandAccountsWrapper.set()methodThis ensures tokens are only stored in the system keychain when keychain-mode is active, avoiding duplicate token storage in cache files.
Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Requires testing in both keychain-mode and netrc-mode configurations.
Setup:
npm i && npm run buildheroku logoutSteps:
Test keychain-mode
./bin/run accounts:add test-account~/.config/heroku/accounts/test-accountcontains onlyusername:(nopassword:field)./bin/run accounts:remove test-accountto remove the account cacheTest netrc-mode
HEROKU_NETRC_WRITE=true ./bin/run accounts:add test-accountusername:andpassword:fields./bin/run accounts:remove test-accountto remove the account cacheScreenshots (if applicable)
N/A
Related Issues
GUS work item: W-23123793