This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Use app_id on plate object instead of reading from Facebook#12
Open
stuartpb wants to merge 1 commit intoheroku:masterfrom
Open
Use app_id on plate object instead of reading from Facebook#12stuartpb wants to merge 1 commit intoheroku:masterfrom
stuartpb wants to merge 1 commit intoheroku:masterfrom
Conversation
Fixes app_id-based bugs from heroku#11.
This was referenced Feb 26, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cases where the app_id is required but not accessible from the API due to the app being hidden from non-logged-in developers (#11).
This doesn't fix other problems stemming from the app information being unreachable (ie. the title of the app). heroku/faceplate#19 potentially may be a fix for those cases. However, the app_id should still be taken from the local configuration and not the remote query.
heroku/faceplate#20 would make this fix even cleaner.