build: auto-discover E2E tests and consolidate test categories#278
Merged
build: auto-discover E2E tests and consolidate test categories#278
Conversation
Replace ~433 manual add_e2e_file_test() registrations with a glob-based auto-discovery loop that scans examples/e2e_*/*.hew for files with matching .expected files. New tests are picked up automatically — no CMakeLists.txt editing needed. Tests that require special runners (sorted output, reject, panic, warn) or WASM-only tests are excluded from auto-discovery and kept as manual registrations. Special cmake properties (RESOURCE_LOCK, PROCESSORS, ENVIRONMENT) are preserved for stress, supervisor, and backpressure tests. Net reduction: ~530 lines removed from CMakeLists.txt.
Merge 19 single-test E2E directories into 5 broader categories:
- e2e_supervisor_{basic,child,named_child,nested,restart,strategy}
→ e2e_supervisor (6 dirs → 1)
- e2e_closure_{coercion,env_rc,firstclass} + e2e_move_closure
→ e2e_closures (4 dirs merged into existing)
- e2e_tuple + e2e_tuple_{destruct,edge} + e2e_nested_tuple_destruct
→ e2e_tuples (4 dirs → 1)
- e2e_struct_{assign,destruct,enum} → e2e_structs (3 dirs → 1)
- e2e_string_{drop,ordering} → e2e_strings (2 dirs merged into existing)
WASM test registrations and set_tests_properties blocks updated to
use the new category names. Auto-discovery handles native E2E tests
automatically.
Exclude e2e_array/dynamic_index and e2e_duration/duration from auto-discovery since they already have legacy inline registrations. Update valgrind-check.sh to reference the new consolidated category paths (e2e_supervisor/, e2e_strings/) after the directory merge.
slepp
force-pushed
the
refactor/build-infrastructure
branch
from
5bbdba9 to
6166859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace ~433 manual
add_e2e_file_test()registrations in CMakeLists.txt witha glob-based auto-discovery loop that scans
examples/e2e_*/*.hewfor fileswith matching
.expectedfiles. New E2E tests are picked up automatically —no CMakeLists.txt editing required.
Consolidate 19 single-test E2E directories into 5 broader categories to reduce
directory clutter.
Changes
Phase 1: Auto-discovery (~530 lines removed from CMakeLists.txt)
e2e_*/*.hew+.expectedpairs automaticallywasm_*prefix) excluded from native auto-discoveryset_tests_properties(RESOURCE_LOCK, PROCESSORS, ENVIRONMENT) preservedPhase 2: Category consolidation (19 dirs → 5)
e2e_supervisor_{basic,child,named_child,nested,restart,strategy}→e2e_supervisore2e_closure_{coercion,env_rc,firstclass}+e2e_move_closure→e2e_closurese2e_tuple+e2e_tuple_{destruct,edge}+e2e_nested_tuple_destruct→e2e_tuplese2e_struct_{assign,destruct,enum}→e2e_structse2e_string_{drop,ordering}→e2e_stringsFixups
dynamic_index,duration) from auto-discoveryto avoid duplicate registrations
scripts/debug/valgrind-check.shto use new consolidated pathsTest results
make test-codegen)make test-rust)make lint)Test name changes
Consolidated categories produce different ctest names. Example:
e2e_supervisor_basic_supervisor_basice2e_supervisor_supervisor_basic