Polish drag-to-rebase and add macOS tests#14
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a drag-and-drop rebase feature for the DAG view, allowing users to rebase commits by dragging them onto new parents. It includes a significant refactoring of the presentation layer to use centralized state management for modals, alerts, and toasts, as well as a version bump to 0.2.12 and the addition of macOS app unit tests. Feedback focuses on performance optimizations, specifically regarding unnecessary view redraws from TimelineView, inefficient O(N) lookups during drag operations, and redundant layout calculations within the view's body.
164abed to
4563a2d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4563a2d832
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b259fe7 to
f1a12d6
Compare
f1a12d6 to
9044e0d
Compare
Summary
This PR polishes the drag-to-rebase interaction in the DAG, consolidates repo-level presentation surfaces, and adds macOS shell unit coverage.
It also bumps JayJay to
0.2.12 (build 16)and adds a top-leveljust test-appcommand that matches the new CI app-test step.What changed
just test-app0.2.12 (build 16)Validation
just buildjust test-appNotes
This is opened as a draft PR so the interaction changes can get one more pass in the app before review.