refactor: remove legacy manual edits JSON manifest render script#869
Closed
miguel-heygen wants to merge 1 commit into
Closed
refactor: remove legacy manual edits JSON manifest render script#869miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Remove the old `.hyperframes/studio-manual-edits.json` sidecar approach that injected a manifest-based runtime into rendered HTML to apply position/rotation/size edits. This was replaced by the seek-reapply script that reads positions directly from HTML data attributes and CSS custom properties (shipped in v0.6.7). Removed: `createStudioManualEditsRenderBodyScript`, `studioManualEditsRenderRuntime`, `STUDIO_MANUAL_EDITS_PATH`, and all references in CLI server, studio vite plugins, and thumbnail routes. Kept: `createStudioPositionSeekReapplyScript` (active render script), all motion panel code, all manual edits DOM code.
miguel-heygen
force-pushed
the
cleanup/remove-legacy-manifest-and-motion-panel
branch
from
f6b6ac3 to
a1fe2b1
Compare
miguel-heygen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
.hyperframes/studio-manual-edits.jsonsidecar approach — the old system that read a JSON manifest and injected a runtime into rendered HTML to apply position/rotation/size edits. This was replaced by the seek-reapply script that reads positions directly from HTML data attributes and CSS custom properties (shipped in v0.6.7).~850 lines removed across 9 files. Motion panel code is not touched — it will be re-architected separately to persist GSAP motion directly to HTML (same approach as manual position edits).
What was removed
createStudioManualEditsRenderBodyScript()and the ~350-linestudioManualEditsRenderRuntime()from coreSTUDIO_MANUAL_EDITS_PATHconstant and all references to.hyperframes/studio-manual-edits.jsonreadStudioManualEditManifestContent,applyStudioManualEditsToThumbnailPage,reapplyStudioManualEditsToThumbnailPage)vite.studioMotion.tsandvite.browser.tsWhat was kept
createStudioPositionSeekReapplyScript()/studioPositionSeekReapplyRuntime()— the active render scriptTest plan
bun run buildpasses