fix(bat): resolve start.bat flash-close on Chinese Windows (#3)#4
Open
heyuqiu2023 wants to merge 1 commit intomainfrom
Open
fix(bat): resolve start.bat flash-close on Chinese Windows (#3)#4heyuqiu2023 wants to merge 1 commit intomainfrom
heyuqiu2023 wants to merge 1 commit intomainfrom
Conversation
Root cause: .bat files were UTF-8 without BOM + LF line endings. Chinese Windows cmd.exe reads .bat files as GBK (CP936) by default, where UTF-8 multibyte leads (0xE2-0xE9) are valid GBK lead bytes that consume the following byte, breaking labels like ':no_node' into 'Ino_node' and causing goto failures + window flash-close. Fixes: Add UTF-8 BOM so Win10+ cmd.exe reads files as UTF-8; move 'chcp 65001 >nul 2>&1' right after '@echo off' in all three files; convert LF line endings to CRLF. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: .bat files were UTF-8 without BOM + LF line endings. Chinese Windows cmd.exe reads .bat files as GBK (CP936) by default, where UTF-8 multibyte leads (0xE2-0xE9) are valid GBK lead bytes that consume the following byte, breaking labels like ':no_node' into 'Ino_node' and causing goto failures + window flash-close.
Fixes: Add UTF-8 BOM so Win10+ cmd.exe reads files as UTF-8; move 'chcp 65001 >nul 2>&1' right after '@echo off' in all three files; convert LF line endings to CRLF.
Closes #3