Fix serve certificate timezone issue#16
Merged
Merged
Conversation
`datetime.now()` returns a `datetime` in the local timezone, but `x509.not_valid_before` expects a `datetime` in UTC (and does not validate this). This causes the self-signed certificate to be not yet valid if the system timezone has a positive offset from UTC.
Owner
|
@TheEdward162 thank you for your contribution! |
hfern
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for publishing this project. I love doing things not in Go.
I ran into an issue with the certificate validation failing (output from Terraform CLI log):
Turns out the self-signed certificate generated by the server is not yet valid if your system timezone has a positive offset from UTC because:
datetime.now()generates adatetimein your local timezone and withtzinfo=Nonex509.CertificateBuilder().not_valid_before()expects adatetimein UTC and treatstzinfo=Noneas UTC (source: https://cryptography.io/en/43.0.3/x509/reference/#cryptography.x509.CertificateBuilder.not_valid_before)So I went ahead and fixed that :)