Improvements across process management utilities#7
Merged
rcalicdan merged 1 commit intohiblaphp:mainfrom May 5, 2026
Merged
Conversation
rcalicdan
approved these changes
May 5, 2026
Member
rcalicdan
left a comment
There was a problem hiding this comment.
This looks fantastic! Thank you for following up so quickly. The implementations here are excellent and especially the use of array_walk_recursive() to solve the emit() array serialization gap (very clean and performant), and the iterative queue refactor in ProcessKiller. You addressed all the agreed-upon points perfectly while respecting the constraints we discussed. I'm approving and merging this now. Thanks again for your contribution to the Hibla ecosystem!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Changes in this PR:
ProcessKiller
SystemUtilities
ExceptionHandler
ProcessSpawnHandler / ProcessManager
BackgroundProcess
ProcessPool
functions.php
phpstan.neon