Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces support for unsubscribing from OSC messages, addressing issue #65. Key changes include:
- Version bumps in library.properties and library.json.
- Updates to README.md documenting new unsubscribe and publish APIs.
- New unsubscribe methods added to OSCServer.h and ArduinoOSCCommon.h.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| library.properties | Bumped version to 0.6.0 to reflect new functionality. |
| library.json | Updated version to 0.6.0 in JSON metadata. |
| README.md | Added documentation for new unsubscribe APIs and updated various OSC API methods. |
| ArduinoOSC/OSCServer.h | Added unsubscribe methods for removing callbacks and unsubscribing by port/address. |
| ArduinoOSC/ArduinoOSCCommon.h | Added unsubscribe methods wrapping server manager functionality with error logging based on WiFi status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #65