fix(cpp): remove function.dispatch scope from identifiers that start with a keyword (#4394)#4403
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4394
Changes
className: 'function.dispatch'fromFUNCTION_DISPATCHso that identifiers that look like function calls are no longer highlighted asbuilt_in\b) to each keyword in the negative lookahead so prefixes are properly handledclassNameAliasesforfunction.dispatchaccordinglyContext
Previously, identifiers such as
testing()were highlighted asbuilt_inbyFUNCTION_DISPATCH, while identifiers starting with a registered keyword (e.g.,for_this(),whilexyz()) were correctly excluded by the negative lookahead. This produced inconsistent highlighting.With this fix,
FUNCTION_DISPATCHstill exists for relevance scoring via_hintkeywords, but it no longer applies a visual scope to the matched text, producing consistent unhighlighted identifiers across the board.