fix(css): extend unicode-range regex to support 6-digit hex values#4406
Open
xxiaoxiong wants to merge 1 commit into
Open
fix(css): extend unicode-range regex to support 6-digit hex values#4406xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
The UNICODE_RANGE regex in css-shared.js limited hex values to a
maximum of 5 digits (1 + {0,4}) for both the prefix and suffix of
a unicode range. CSS unicode-range supports hex values up to 6
digits (e.g., U+10FFFF, U+0-10FFFF).
Updated {0,4} to {0,5} to properly match these longer values.
Fixes highlightjs#4253
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extended the UNICODE_RANGE regex in
css-shared.jsto support hex values up to 6 digits (e.g.,U+10FFFF,U+0-10FFFF). The previous regex limited hexadecimal digits to 5 positions, causing values likeU+10FFFFto be truncated toU+10FFF.Changed
{0,4}to{0,5}in both the prefix and suffix of the unicode range pattern to comply with the CSS spec which supports 1–6 digit hex values.Related Issue
Closes #4253
Testing
Verified the fix with:
U+0-10FFFF(full Unicode range)U+000-5FF,U+1e00-1fff,U+2000-2300(existing cases still work)U+4?????(wildcards with up to 6 ?)Checklist
CHANGES.md