fix(cpp): add word boundary to float literal pattern#4407
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
Closes highlightjs#4231 The floating-point literal regex was missing \b (word boundary) at the start of its digit-based alternatives, causing identifiers like to incorrectly highlight as a float literal. Added \b to each numeric alternative that starts with a digit, while preserving the existing behavior for leading-dot floats (e.g. ). Fixes highlightjs#4231
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In C++ code, identifiers that contain digits following a float pattern (e.g.,
var2_5) are incorrectly highlighted as float literals. The number5invar2_5triggers the float literal regex.Root cause
The C++ float literal pattern lacks a word boundary assertion at the beginning. Without it, the regex matches substrings like
2_5within a larger identifiervar2_5.Changes
src/languages/cpp.js: Added a word boundary (\b) at the start of the float literal regex pattern to ensure only standalone numeric literals are matched, not digits embedded within identifiers.Why
Without the word boundary, any identifier ending in digits suffixed with a numeric-looking segment would be partially matched as a float literal, breaking variable name highlighting.
Closes #4231