fix(ruby): wrong recognition of symbols after namespace qualifier#4408
Open
xxiaoxiong wants to merge 2 commits into
Open
fix(ruby): wrong recognition of symbols after namespace qualifier#4408xxiaoxiong wants to merge 2 commits into
xxiaoxiong wants to merge 2 commits into
Conversation
Closes highlightjs#4231 The floating-point literal regex was missing \b (word boundary) at the start of its digit-based alternatives, causing identifiers like to incorrectly highlight as a float literal. Added \b to each numeric alternative that starts with a digit, while preserving the existing behavior for leading-dot floats (e.g. ). Fixes highlightjs#4231
fixes highlightjs#4294 The symbol regex :(?!\s) was too broad — it matched ::method in ClassName::method as a symbol. This commit tightens the regex to :(?![:\s]) so ::method's first colon (followed by :) is not matched, and adds an on:begin guard to reject the second colon when preceded by another colon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4294