fix(bash): heredoc regex should not match pipe at end of line#4409
Open
xxiaoxiong wants to merge 1 commit into
Open
fix(bash): heredoc regex should not match pipe at end of line#4409xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
When a here-document is followed by a pipe (e.g., <<-EOF | cat), the current heredoc regex () matches the entire rest of the line, causing the contents after the pipe to be incorrectly highlighted as part of the heredoc string. This fix adds a negative lookahead to the heredoc regex to stop matching when a pipe operator follows the heredoc delimiter keyword. Fixes highlightjs#4377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4377
Problem
When a here-document is followed by a pipe (e.g.,
echo "ok" <<-EOF | cat), the current heredocbeginregex (<<-?\s*(\w+)\b.*) matches the entire rest of the line, causing| catto be incorrectly highlighted as part of the heredoc string (scope:string), socatdoes not get recognized as abuilt_in.Fix
Add a negative lookahead
(?!\s*\|)to the heredocbeginregex. This prevents the heredoc from being triggered when a pipe operator follows the delimiter keyword, allowing pipe-separated commands to be highlighted correctly.Before (rendered HTML)
After (rendered HTML)
Test
heredoc-redirectmarkup test covering heredoc followed by pipestringsmarkup test updated for improved rendering behavior