fix(javascript): add 'self' as a built-in variable (#4339)#4410
Closed
xxiaoxiong wants to merge 1 commit into
Closed
fix(javascript): add 'self' as a built-in variable (#4339)#4410xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
'self' (Window.self) is a standard browser global that should be highlighted as a variable.language, consistent with 'window' and 'document'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
selfis a standard Web API global available in both window and Worker contexts, equivalent towindowin browsing contexts. However, the JavaScript grammar does not includeselfin its built-in variable list, so it is not syntax highlighted like other globals.Changes
src/languages/javascript.js: Added'self'to theBUILT_IN_VARIABLESarray alongside existing entries likewindow,globalThis, andglobal.Why
selfis a standard Web API global (Window.self,WorkerGlobalScope.self). It should be highlighted consistently with other global objects for proper syntax clarity.Closes #4339