fix(php-template): add line comment support to prevent quote chars from breaking highlighting#4411
Open
xxiaoxiong wants to merge 1 commit into
Open
Conversation
…om breaking highlighting A single apostrophe ' inside a // or # line comment inside a <?php block would be matched by the APOS_STRING_MODE rule before PHP's comment parser could consume it, causing all subsequent highlighting to break. Added // and # line comment blocks with skip:true before the string mode rules in the php-template contains array, ensuring comments are consumed first. Fixes highlightjs#4152 Co-authored-by: xxiaoxiong <xxiaoxiong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4152
Why
A single apostrophe
'inside a//or#line comment inside a<?phpblock in a PHP template would be matched by theAPOS_STRING_MODErule before PHP's comment parser could consume it. This caused all subsequent highlighting in the PHP block to break.Example that was broken:
Changes
Added
//and#line comment blocks withskip: trueto thecontainsarray inphp-template.js, positioned before the string mode rules so comments are consumed first.Testing
// don'tin comment no longer breaks highlighting# don'tin comment no longer breaks highlighting/* block comments */continue to workdefault) passes unchangedapostrophe) added for regression coverageSurface area