refactor(connector): extract shared wire types#12
Conversation
Moves createReq, updateReq, configEnvelope, postgresSpec, createResp, and getConnectorResp out of create.go / update.go into types.go. Pure relocation — tests and coverage unchanged — but it gives the upcoming dialect split a seam: per-dialect spec types will land as types_snowflake.go / types_databricks.go without churning create.go or update.go.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughA refactoring that consolidates duplicate type definitions from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Pure relocation of connector wire types out of create.go / update.go into a new types.go:
createReq,updateReq,configEnvelope,postgresSpec,createResp,getConnectorResp.No behavioral change. Sets up the seam for per-dialect spec types (
types_snowflake.go,types_databricks.go) without churning create.go or update.go.Summary by CodeRabbit