Skip to content

ci: rename deprecated app-id input to client-id#31

Merged
bradfair merged 1 commit into
mainfrom
fix/release-please-client-id
Apr 23, 2026
Merged

ci: rename deprecated app-id input to client-id#31
bradfair merged 1 commit into
mainfrom
fix/release-please-client-id

Conversation

@bradfair

@bradfair bradfair commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Rename app-idclient-id on actions/create-github-app-token in release-please.yml to clear the deprecation warning.
  • Secret name HPT_BOT_APP_ID is unchanged; only the workflow input key moves.

Closes #9

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration for GitHub App token generation in the release pipeline.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d3b98f9e-9a5a-408a-ba47-fe77ce50c7d6

📥 Commits

Reviewing files that changed from the base of the PR and between c931d8d and 154b3e3.

📒 Files selected for processing (1)
  • .github/workflows/release-please.yml

📝 Walkthrough

Walkthrough

The release-please.yml workflow updates the GitHub Actions token creation step to use the client-id input parameter instead of the deprecated app-id parameter, while maintaining the same secret reference for the application identifier.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/release-please.yml
Renamed app-id input to client-id in actions/create-github-app-token action invocation to address deprecation warning. Secret reference remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A token input, renamed with care,
From app-id's old way, now client-id fair,
The secret stays put, no fuss or fight,
Just a simple swap to make workflows right! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides a summary of changes but omits required sections like Type checklist and Checklist items specified in the template. Add the Type section (marking ci as the change type) and complete the Checklist items (PR title, lint, cover, docs) as required by the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: renaming the deprecated app-id input parameter to client-id in the CI workflow.
Linked Issues check ✅ Passed The code change directly addresses issue #9 by renaming the app-id input to client-id in the release-please workflow, matching the acceptance criteria.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the single required update: renaming the workflow input parameter from app-id to client-id with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-please-client-id

Comment @coderabbitai help to get the list of available commands and usage tips.

@bradfair bradfair added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit eed085c Apr 23, 2026
10 checks passed
@bradfair bradfair deleted the fix/release-please-client-id branch April 23, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: release-please workflow app-id input deprecated, rename to client-id

1 participant