Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the Slidev skill from a vendored submodule to a Claude Code plugin marketplace setup, updating references to the new plugin-qualified skill name.
Changes:
- Removed the vendored Slidev skill wiring and the flake input previously used to source it.
- Added a local marketplace manifest for external skills and moved the Slidev submodule under
external-skills/. - Updated docs/config to reference
Skill(slidev-plugin:slidev)and documented marketplace installation steps.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| home/modules/claude-code/files/skills/slidev | Removes the old vendored pointer to Slidev skill. |
| home/modules/claude-code/files/skills/research-presentation/roles/presentation.md | Updates Slidev skill invocation to plugin-qualified name. |
| home/modules/claude-code/files/skills/research-presentation/SKILL.md | Updates instructions to load Slidev via plugin-qualified skill. |
| home/modules/claude-code/files/skills/my-slidev/SKILL.md | Updates references to Slidev syntax docs to plugin-qualified skill path. |
| home/modules/claude-code/files/settings.json | Allows gh pr list and switches allowed skill from slidev to slidev-plugin:slidev. |
| home/modules/claude-code/files/external-skills/.claude-plugin/marketplace.json | Introduces local marketplace manifest defining the Slidev plugin. |
| home/modules/claude-code/files/README.md | Documents external skills marketplace usage and install commands. |
| home/modules/claude-code/files/CLAUDE.md | Updates /my-slidev docs to reference the new Slidev plugin skill. |
| home/modules/claude-code/files/.claude/CLAUDE.md | Replaces vendor/ docs with external-skills/ docs. |
| home/modules/claude-code/default.nix | Stops deploying Slidev skill via inputs.slidev-src. |
| flake.nix | Removes the slidev-src input previously used for vendoring. |
| README.md | Adds external-skills/ to the repository tree list. |
| .gitmodules | Moves the Slidev submodule path from vendor/ to external-skills/. |
Comments suppressed due to low confidence (1)
README.md:1
- This README advertises a top-level "external-skills/" directory, but the submodule path in this PR is under "home/modules/claude-code/files/external-skills/slidev". If the repo does not actually contain a root-level external-skills directory, update the tree here to match the real location (or move/create the directory at the repo root to match the docs).
# config
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| "Bash(gh issue view *)", | ||
| "Bash(gh pr checks *)", | ||
| "Bash(gh pr diff *)", | ||
| "Bash(gh pr list)", |
Comment on lines
+30
to
+34
| External skills managed via Claude Code's plugin marketplace system. The `external-skills/` directory contains a marketplace manifest (`.claude-plugin/marketplace.json`) and git submodules pointing to upstream skill repositories. | ||
|
|
||
| ```bash | ||
| # Register the local marketplace (one-time) | ||
| /plugin marketplace add ./external-skills |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.