Skip to content

RFC: composer 2 compatibility#239

Open
c33s wants to merge 1 commit into
hirak:masterfrom
c33s:feature/composer2-compat
Open

RFC: composer 2 compatibility#239
c33s wants to merge 1 commit into
hirak:masterfrom
c33s:feature/composer2-compat

Conversation

@c33s

@c33s c33s commented Nov 1, 2020

Copy link
Copy Markdown

a quick hack to allow the plugin to exist in environments where composer1 and composer2 are used. if composer2 is detected is simply deactivate itself.
i am quite sure there are better ways to archive that but i just want a quick solution for myself.

  • no additional test cases added.
  • manually tested with composer 1.10.16 and 2.0.3

to try it out add the following to your composer.json

{
    "repositories": {
        "prestissimo": {
            "type": "vcs",
            "url": "https://github.com/c33s/prestissimo.git"
        }
    },
    "require": {
        "hirak/prestissimo": "dev-feature/composer2-compat",
    }
}

@Berdir

Berdir commented Nov 2, 2020

Copy link
Copy Markdown

FWIW, this is the same approach that for example zaporylie/composer-drupal-optimizations#17 chose as well, which has worked well there, so +1.

@Tobion

Tobion commented Dec 8, 2020

Copy link
Copy Markdown

Duplicate of #223 which has been declined

@c33s

c33s commented Dec 8, 2020

Copy link
Copy Markdown
Author

Duplicate of #223 which has been declined

still required for an easy transition from composer1 to composer2

ci's break because of this

@kubawerlos

Copy link
Copy Markdown
Contributor

ci's break because of this

Yes, but @hirak said he won't release a new version. composer self-update --2 is the best workaround I guess.

@c33s

c33s commented Dec 8, 2020

Copy link
Copy Markdown
Author

Yes, but @hirak said he won't release a new version.

one more version is not that difficult or cumbersome.

composer self-update --2 is the best workaround I guess.

this is no workaround for multi environments (composer1 and composer2) see also the comment of @vworldat #233 (comment)

@kubawerlos

Copy link
Copy Markdown
Contributor

one more version is not that difficult or cumbersome.

You don't have to convince me, after all, I made #223

this is no workaround for multi environments

Well, I managed with the help of composer self-update --1/composer self-update --2 to handle such situation, not perfect, but woroking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants