feat: pox-4 support by zone117x · Pull Request #1754 · hirosystems/stacks-blockchain-api

zone117x · 2023-12-01T10:30:12Z

Force-unlock / sunsetting code for pox-3 locks
Ingestion for pox-4 events
Initial ingestion for revoke-delegate-stx

Tests for pox-4 have been implemented in a separate PR to make things easier to review: #1762

codecov · 2023-12-01T10:32:20Z

Codecov Report

Attention: 162 lines in your changes are missing coverage. Please review.

Comparison is base (7c45f53) 70.84% compared to head (f46a19e) 71.45%.
Report is 1 commits behind head on nakamoto.

Files	Patch %	Lines
src/event-stream/pox-event-parsing.ts	4.54%	42 Missing ⚠️
src/datastore/pg-store.ts	64.83%	30 Missing and 2 partials ⚠️
src/api/routes/pox.ts	62.16%	27 Missing and 1 partial ⚠️
src/datastore/pg-write-store.ts	30.30%	23 Missing ⚠️
src/event-stream/event-server.ts	11.11%	14 Missing and 2 partials ⚠️
...play/parquet-based/importers/new-block-importer.ts	0.00%	6 Missing ⚠️
src/api/controllers/db-controller.ts	82.60%	4 Missing ⚠️
src/api/init.ts	84.21%	3 Missing ⚠️
src/api/query-helpers.ts	83.33%	3 Missing ⚠️
src/datastore/helpers.ts	90.00%	3 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff              @@
##           nakamoto    #1754      +/-   ##
============================================
+ Coverage     70.84%   71.45%   +0.61%     
============================================
  Files            86       86              
  Lines         11541    11589      +48     
  Branches       2516     2535      +19     
============================================
+ Hits           8176     8281     +105     
+ Misses         3213     3158      -55     
+ Partials        152      150       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-01T10:32:52Z

Vercel deployment URL: https://stacks-blockchain-grrzuc1vh-blockstack.vercel.app 🚀

…tx event

rafaelcr

Nice!

janniks · 2023-12-12T15:46:32Z

src/api/controllers/db-controller.ts

+        ...baseInfo,
+        data: {
+          amount_ustx: poxEvent.data.amount_ustx.toString(),
+          delegate_to: poxEvent.data.delegate_to,


I'm curious where this part is in the stacks-core codebase (haven't been able to find, would love to peek at that code)

The synthetic pox events are at https://github.com/stacks-network/stacks-core/blob/next/pox-locking/src/events.rs
This revoke one is WIP stacks-network/stacks-core#4157

# Conflicts: # src/api/init.ts

janniks · 2023-12-12T16:47:55Z

src/datastore/common.ts

+  data: {
+    // TODO: determine what data is available for this event type
+    amount_ustx: bigint;
+    delegate_to: string;


I'm assuming only the sender address is available (given pox clar code), but not sure how much more the node will provide.

The WIP PR stacks-network/stacks-core#4157 is likely to add more data. There will probably be a follow-up API PR once that is ready

janniks

Looking good 👍

## [7.4.0-nakamoto.3](v7.4.0-nakamoto.2...v7.4.0-nakamoto.3) (2023-12-13) ### Features * `GET /extended/v1/burn_block` ([#1766](#1766)) ([cb38b68](cb38b68)) * ingestion for `TenureChange` and `NakamotoCoinbase` tx types ([#1753](#1753)) ([7c45f53](7c45f53)) * pox-4 support ([#1754](#1754)) ([285806f](285806f))

blockstack-devops · 2023-12-13T12:05:07Z

🎉 This PR is included in version 7.4.0-nakamoto.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.6.0-nakamoto.1](v7.5.0...v7.6.0-nakamoto.1) (2024-01-09) ### Features * `GET /extended/v1/burn_block` ([#1766](#1766)) ([cb38b68](cb38b68)) * add `/extended/v2/blocks/:height_or_hash` ([#1774](#1774)) ([e532a5e](e532a5e)) * add `/extended/v2/blocks` endpoint with burn block filters ([#1769](#1769)) ([ceb7be0](ceb7be0)) * add `tx_count` property to `/extended/v2/blocks` ([#1778](#1778)) ([da4cd56](da4cd56)) * add dataset store ([4211328](4211328)) * add step to compile duckdb for Alpine image ([0f40e14](0f40e14)) * better handling of raw events insertion ([bb70ca9](bb70ca9)) * create `/extended/v2/burn-blocks/:height_or_hash/blocks` endpoint ([#1782](#1782)) ([20466a1](20466a1)) * disable rosetta via an ENV var ([#1804](#1804)) ([2d2aee3](2d2aee3)) * event-replay new_block events handling ([1708b42](1708b42)) * event-replay new_burn_block events handling ([6c0f448](6c0f448)) * event-replay raw events handling ([81f43cf](81f43cf)) * event-replay remainder events handling ([3ede07f](3ede07f)) * event-replay supporting parallel insertions ([f33ecee](f33ecee)) * events folder as environment var ([701bd1a](701bd1a)) * ingestion for `TenureChange` and `NakamotoCoinbase` tx types ([#1753](#1753)) ([7c45f53](7c45f53)) * parallel processing using node cluster ([d02a7e8](d02a7e8)) * pox-4 support ([#1754](#1754)) ([285806f](285806f)) * processing raw events in parallel ([7a6f241](7a6f241)) * update to latest TenureChange tx payload ([#1767](#1767)) ([2afb65c](2afb65c)) ### Bug Fixes * add token offering ([8ef039e](8ef039e)) * allow contract-principals in `/extended/v1/address/:principal/mempool` endpoint [#1685](#1685) ([#1704](#1704)) ([163b76a](163b76a)) * better args handlling ([c77ac57](c77ac57)) * better path handling for workers ([1bd8f17](1bd8f17)) * changed processing order ([62a12bd](62a12bd)) * convert `chain_tip` materialized view into a table ([#1751](#1751)) ([04b71cc](04b71cc)) * do not load duckdb binary unless required ([#1776](#1776)) ([db859ae](db859ae)) * flaky test ([484d2ea](484d2ea)) * flaky test ([65175f5](65175f5)) * handle `Problematic` status in `/drop_mempool_tx` event ([#1790](#1790)) ([ce9b38f](ce9b38f)) * import statement in replay controller ([7a10cd8](7a10cd8)) * insert block transaction data in batches ([#1760](#1760)) ([bf99e90](bf99e90)) * lint ([01589ea](01589ea)) * lint ([82eadcb](82eadcb)) * lint ([8c67ae5](8c67ae5)) * move `/extended/v1/burn_block` to `/extended/v2/burn-blocks` ([#1772](#1772)) ([bf2ef0a](bf2ef0a)) * on attachments_new events processing ([0707313](0707313)) * optimize mempool transaction reads and writes ([#1781](#1781)) ([3a02f57](3a02f57)) * re-enable indexes when finishing the replay ([fc379eb](fc379eb)) * remove dangling promise ([62a48ae](62a48ae)) * remove deprecated token endpoints ([#1775](#1775)) ([18f74b7](18f74b7)) * revert configurable DB index type ([86154b2](86154b2)) * upgrade semver package to fix ReDoS vulnerability ([6b1605b](6b1605b)) * vercel preview builds ([#1783](#1783)) ([d36b1c2](d36b1c2))

blockstack-devops · 2024-01-09T14:39:50Z

🎉 This PR is included in version 7.6.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.6.0](v7.5.0...v7.6.0) (2024-01-09) ### Features * `GET /extended/v1/burn_block` ([#1766](#1766)) ([cb38b68](cb38b68)) * add `/extended/v2/blocks/:height_or_hash` ([#1774](#1774)) ([e532a5e](e532a5e)) * add `/extended/v2/blocks` endpoint with burn block filters ([#1769](#1769)) ([ceb7be0](ceb7be0)) * add `order_by` and `order` params to `/extended/v1/tx/mempool` ([#1810](#1810)) ([2d45b2e](2d45b2e)) * add `tx_count` property to `/extended/v2/blocks` ([#1778](#1778)) ([da4cd56](da4cd56)) * add dataset store ([4211328](4211328)) * add step to compile duckdb for Alpine image ([0f40e14](0f40e14)) * better handling of raw events insertion ([bb70ca9](bb70ca9)) * create `/extended/v2/burn-blocks/:height_or_hash/blocks` endpoint ([#1782](#1782)) ([20466a1](20466a1)) * disable rosetta via an ENV var ([#1804](#1804)) ([2d2aee3](2d2aee3)) * event-replay new_block events handling ([1708b42](1708b42)) * event-replay new_burn_block events handling ([6c0f448](6c0f448)) * event-replay raw events handling ([81f43cf](81f43cf)) * event-replay remainder events handling ([3ede07f](3ede07f)) * event-replay supporting parallel insertions ([f33ecee](f33ecee)) * events folder as environment var ([701bd1a](701bd1a)) * ingestion for `TenureChange` and `NakamotoCoinbase` tx types ([#1753](#1753)) ([7c45f53](7c45f53)) * parallel processing using node cluster ([d02a7e8](d02a7e8)) * pox-4 support ([#1754](#1754)) ([285806f](285806f)) * processing raw events in parallel ([7a6f241](7a6f241)) * support tenure_change in tx type filter queries ([#1808](#1808)) ([0831393](0831393)) * update to latest TenureChange tx payload ([#1767](#1767)) ([2afb65c](2afb65c)) ### Bug Fixes * add token offering ([8ef039e](8ef039e)) * allow contract-principals in `/extended/v1/address/:principal/mempool` endpoint [#1685](#1685) ([#1704](#1704)) ([163b76a](163b76a)) * better args handlling ([c77ac57](c77ac57)) * better path handling for workers ([1bd8f17](1bd8f17)) * changed processing order ([62a12bd](62a12bd)) * convert `chain_tip` materialized view into a table ([#1751](#1751)) ([04b71cc](04b71cc)) * do not load duckdb binary unless required ([#1776](#1776)) ([db859ae](db859ae)) * **docs:** URL query arrays should be formatted with `form` rather than comma-separated ([#1807](#1807)) ([e184fb5](e184fb5)) * flaky test ([484d2ea](484d2ea)) * flaky test ([65175f5](65175f5)) * handle `Problematic` status in `/drop_mempool_tx` event ([#1790](#1790)) ([ce9b38f](ce9b38f)) * import statement in replay controller ([7a10cd8](7a10cd8)) * insert block transaction data in batches ([#1760](#1760)) ([bf99e90](bf99e90)) * lint ([01589ea](01589ea)) * lint ([82eadcb](82eadcb)) * lint ([8c67ae5](8c67ae5)) * move `/extended/v1/burn_block` to `/extended/v2/burn-blocks` ([#1772](#1772)) ([bf2ef0a](bf2ef0a)) * on attachments_new events processing ([0707313](0707313)) * optimize mempool transaction reads and writes ([#1781](#1781)) ([3a02f57](3a02f57)) * re-enable indexes when finishing the replay ([fc379eb](fc379eb)) * remove dangling promise ([62a48ae](62a48ae)) * remove deprecated token endpoints ([#1775](#1775)) ([18f74b7](18f74b7)) * revert configurable DB index type ([86154b2](86154b2)) * support comma-separated strings in array query params ([#1809](#1809)) ([c9a4df8](c9a4df8)) * upgrade semver package to fix ReDoS vulnerability ([6b1605b](6b1605b)) * vercel preview builds ([#1783](#1783)) ([d36b1c2](d36b1c2))

blockstack-devops · 2024-01-09T17:24:34Z

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zone117x temporarily deployed to Preview December 1, 2023 10:30 — with GitHub Actions Inactive

zone117x temporarily deployed to Preview December 8, 2023 10:01 — with GitHub Actions Inactive

Base automatically changed from feat/nakamoto-txs to nakamoto December 8, 2023 11:39

zone117x added 3 commits December 9, 2023 11:48

feat: handle pox-3 force unlocks

37bdb83

chore: todo note

0359fe7

feat: handle pox-3 force unlocks, pox-4 events, and revoke-delegate-s…

aad6cca

…tx event

zone117x force-pushed the feat/pox-3-force-unlocks branch from a5a4be6 to aad6cca Compare December 9, 2023 12:58

zone117x temporarily deployed to Preview December 9, 2023 12:58 — with GitHub Actions Inactive

chore: rename pox-2 file

f1e3ff0

zone117x temporarily deployed to Preview December 9, 2023 13:03 — with GitHub Actions Inactive

zone117x changed the title ~~feat: handle pox-3 force unlocks~~ feat: pox-4 support Dec 9, 2023

chore: simplified pox route paths

cd7b3ff

zone117x temporarily deployed to Preview December 9, 2023 14:59 — with GitHub Actions Inactive

feat: add migration to create pox4_events table

cddfaa2

zone117x temporarily deployed to Preview December 9, 2023 15:13 — with GitHub Actions Inactive

test: follow redirects in test fetch helper

9f1541b

zone117x temporarily deployed to Preview December 9, 2023 15:24 — with GitHub Actions Inactive

chore: fix storing different pox version events

bed4c6e

zone117x temporarily deployed to Preview December 9, 2023 15:46 — with GitHub Actions Inactive

test: fix tests with missing pox4_events

85ec974

zone117x temporarily deployed to Preview December 9, 2023 16:00 — with GitHub Actions Inactive

chore: move delegations lookup endpoint into pox router

dd9813a

zone117x temporarily deployed to Preview December 9, 2023 16:26 — with GitHub Actions Inactive

fix: handle pox4_events during reorgs

3b4325e

zone117x temporarily deployed to Preview December 9, 2023 16:31 — with GitHub Actions Inactive

test: fix pox4events reorg count

d0b2f09

zone117x temporarily deployed to Preview December 9, 2023 16:38 — with GitHub Actions Inactive

zone117x marked this pull request as ready for review December 10, 2023 14:42

zone117x mentioned this pull request Dec 11, 2023

[Nakamoto] Support pox-4 changes #1735

Closed

rafaelcr approved these changes Dec 12, 2023

View reviewed changes

zone117x added 10 commits December 12, 2023 16:14

chore: update stacks-node image to stacks 3.0

3f7f144

test: begin transitioning pox tests to use pox-4

007bae3

chore: bump stacks-node to wip nakamoto branch

753b8a4

test: switch more tests from pox-3 to pox-4

7e5d368

fix: tx fee fall back in faucet

6b7d5f4

test: update delegation check endpoints

b7bf986

chore: isolate error in delegate-revoke test

ff6c611

chore: pox3 to pox4 misc renames

fbdf822

ci: rename 2.4 to 2.5

d5fb7d1

test: remove no-longer applicable delegate-stx while stacking test

f8b4aa8

zone117x temporarily deployed to Preview December 12, 2023 15:14 — with GitHub Actions Inactive

chore: remove incorrect commend in pox4 test

d8c91d5

zone117x temporarily deployed to Preview December 12, 2023 15:17 — with GitHub Actions Inactive

janniks reviewed Dec 12, 2023

View reviewed changes

Merge branch 'nakamoto' into feat/pox-3-force-unlocks

f46a19e

# Conflicts: # src/api/init.ts

zone117x temporarily deployed to Preview December 12, 2023 16:35 — with GitHub Actions Inactive

janniks reviewed Dec 12, 2023

View reviewed changes

janniks approved these changes Dec 13, 2023

View reviewed changes

zone117x merged commit 285806f into nakamoto Dec 13, 2023

zone117x deleted the feat/pox-3-force-unlocks branch December 13, 2023 11:58

blockstack-devops added the released on @nakamoto label Dec 13, 2023

blockstack-devops added the released label Jan 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: pox-4 support#1754

feat: pox-4 support#1754
zone117x merged 24 commits intonakamotofrom
feat/pox-3-force-unlocks

zone117x commented Dec 1, 2023 •

edited

Loading

Uh oh!

codecov bot commented Dec 1, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2023 •

edited

Loading

Uh oh!

rafaelcr left a comment

Uh oh!

janniks Dec 12, 2023

Uh oh!

zone117x Dec 12, 2023

Uh oh!

janniks Dec 12, 2023

Uh oh!

zone117x Dec 12, 2023

Uh oh!

janniks left a comment

Uh oh!

blockstack-devops commented Dec 13, 2023

Uh oh!

blockstack-devops commented Jan 9, 2024

Uh oh!

blockstack-devops commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zone117x commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelcr left a comment

Choose a reason for hiding this comment

Uh oh!

janniks Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

zone117x Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

janniks Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

zone117x Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

janniks left a comment

Choose a reason for hiding this comment

Uh oh!

blockstack-devops commented Dec 13, 2023

Uh oh!

blockstack-devops commented Jan 9, 2024

Uh oh!

blockstack-devops commented Jan 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zone117x commented Dec 1, 2023 •

edited

Loading

codecov bot commented Dec 1, 2023 •

edited

Loading

github-actions bot commented Dec 1, 2023 •

edited

Loading