Easier linux development via docker and linux fixes#25
Open
SebiAi wants to merge 2 commits intohlavacs:mainfrom
Open
Easier linux development via docker and linux fixes#25SebiAi wants to merge 2 commits intohlavacs:mainfrom
SebiAi wants to merge 2 commits intohlavacs:mainfrom
Conversation
Fixes in *physics* target * `error: constexpr function never produces a constant expression [-Winvalid-constexpr]` for `fromPhysics`/`toPhysics` functions * `error: no matching member function for call to 'maxFaceAlignment'` via explicit static cast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to make working with VVE, VECS and VPE easier/possible on linux by removing MSVC specific macros and resolve compile errors.
This commit fixes VPE for the physics example (see hlavacs/ViennaPhysicsEngine#2) and adds a way to build, run and debug the project via a development docker container. This eliminates the need for installing all the dependencies on ones system. One caveat I found is that games compiled in the environment can not be run on the main system.
See the linux specific readme on how to use the devcontainer with VSCode.
I've also submitted a compile fix for hlavacs/ViennaEntityComponentSystem#1 since VVE depends on it. Without these patches in the VECS, VVE will not compile without errors.
Note
These patches only fix compile errors. There are still plenty of compile warnings in VVE which will need to be addressed separately. Even with these warnings the physics and game examples work as expected.