Skip to content

fix: follow site drift (VoteBridgeNew .jsp→.xhtml and btnSubmit CSS scope) (#115) #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nishimaki wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: follow site drift (VoteBridgeNew .jsp→.xhtml and btnSubmit CSS scope) (#115) #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c970307
fix: update IBMBRACEORJP to .xhtml to follow site drift
nishimaki Apr 14, 2026
22a05a9
fix: scope btnSubmit selector to .inputCompletion to avoid stray clicks
nishimaki Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyjpboatrace/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

IBMBRACEORJP = ''.join([
f'{BOATRACEJP_MAIN_URL}',
'owpc/VoteBridgeNew.jsp?',
'owpc/VoteBridgeNew.xhtml?',
'param=H0JS00000stContens'
'&kbn=1'
'&voteActionUrl=/owpc/pc/site/index.html'
Expand Down
12 changes: 9 additions & 3 deletions pyjpboatrace/operator/better.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,11 @@ def __bet(

amount = amount + amt

# complete input
self._driver.find_element(By.CLASS_NAME, 'btnSubmit').click()
# complete input (target the "投票入力完了" button inside .inputCompletion;
# plain CLASS_NAME 'btnSubmit' also matches hidden password-change forms)
self._driver.find_element(
By.CSS_SELECTOR, '.inputCompletion .btnSubmit a'
).click()

# insufficient depost
if amount > limit:
Expand All @@ -170,7 +173,10 @@ def __bet(
f'but your current deposit is {limit}.'
)

# confirmation
# confirmation page — wait for the betconf DOM to appear
WebDriverWait(self._driver, timeout).until(
EC.presence_of_element_located((By.ID, 'pass'))
)
Comment on lines 162 to +179

Copilot AI Apr 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters the Selenium calls made by __bet (switching the submit click from By.CLASS_NAME, 'btnSubmit' to a CSS selector, and adding a WebDriverWait that will call find_element(By.ID, 'pass')). The unit test tests/operator/test_better.py::test_betting_operator_do currently asserts the old (By.CLASS_NAME, 'btnSubmit') call and the previous call order, so it will fail unless updated to expect the new selector and the additional pass lookup triggered by the wait.

Copilot uses AI. Check for mistakes.
self._driver.find_element(By.ID, 'amount').send_keys(str(amount))
self._driver.find_element(By.ID, 'pass').send_keys(self._user.vote_pass) # noqa
self._driver.find_element(By.ID, 'submitBet').click()
Expand Down