Remove stale maven-plugin-annotations.version=3.9.0 override#172
Open
allanmckenzie wants to merge 1 commit into
Open
Remove stale maven-plugin-annotations.version=3.9.0 override#172allanmckenzie wants to merge 1 commit into
allanmckenzie wants to merge 1 commit into
Conversation
The BOM already manages maven-plugin-annotations at 3.15.2. The local property override pinned it to the older 3.9.0, silently suppressing the BOM version. The annotation-validator-maven-plugin had an explicit <version> tag referencing this property; removing both lets the BOM manage the version correctly.
allanmckenzie
requested review from
oktayekincioglu,
santhosh-hmcts and
zozd-hmcts
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-plugin-annotations.version=3.9.0from the root pom. The BOM (cp-maven-common-bom) already managesmaven-plugin-annotationsat 3.15.2; the local property was silently overriding it with an older version. The comment in the pom even noted "Must be moved to parent-pom" — this was a recognised stale entry<version>${maven-plugin-annotations.version}</version>fromannotation-validator-maven-plugin/pom.xmlso the BOM manages the versionTest plan
mvn clean install -pl annotation-validator/annotation-validator-maven-plugin,generator-maven-plugin/generator-plugin,raml-maven/raml-maven-plugin -am— all passmaven-jar-pluginempty-source failures in IT/testing utility modules are unrelated to this change)