SPRDT-874: Adjournment CROWN journey updates#318
Open
ragubalan wants to merge 4 commits into
Open
Conversation
ragubalan
requested review from
JayalakshmiParthiban,
danielwilsonkainos and
kumarsajan1983
and removed request for
a team
ragubalan
requested review from
ozturkmenb
and removed request for
JayalakshmiParthiban,
danielwilsonkainos and
kumarsajan1983
|
|
…-as-courtScheduleId behaviour Crown next hearings with a bookingReference absent from the provisional booking slots map use the bookingReference itself as the courtScheduleId rather than warning and skipping. Update the NHCC test to assert that behaviour and add a separate NHMC (Magistrates) test confirming the warn-and-skip path is unchanged for non-Crown jurisdictions.
|
|
Contributor
Integration test run —
|
| Metric | Count |
|---|---|
| Tests run | 351 |
| Failures | 2 |
| Errors | 0 |
| Skipped | 8 |
| Suite time | 22:35 min |
| Total build | 23:19 min |
Failures — both unrelated to this PR
This PR's change is confined to HearingToHearingListingNeedsTransformer tests + UnscheduledCourtHearingListTransformer. The two failing IT classes are in unrelated domains (representation-order messaging, defendant ingester) and do not exercise the listing-needs / Crown bookingReference path:
ReceiveRepresentationOrderForApplicationIT.shouldRaisePublicEventWhenApplicationIsFoundForReceiveRepresentationOrderForApplicationWithOrganisation
→verifyInMessagingQueueForApplication:181—Expected: is <true> but: was <false>(JMS public-event queue assertion; looks like an awaitility timing flake).ProsecutionCaseDefendantUpdatedIngesterIT.shouldUpdateDefendant:74.
This PR's coverage passed
The changed unit suite ran green:
HearingToHearingListingNeedsTransformerTest— 32 tests, 0 failures, 0 errors, 0 skipped.
The upstream surefire (unit) layers all reported Failures: 0. Recommend a re-run of the two flaky ITs to confirm they go green on a clean stack; they are not caused by this change.
Contributor
Re-run (full suite) —
|
| Metric | Run 1 | Run 2 (re-run) |
|---|---|---|
| Tests run | 351 | 351 |
| Failures | 2 | 1 |
| Errors | 0 | 0 |
| Skipped | 8 | 8 |
| Build time | 23:19 min | 23:12 min |
Outcome per failure
- ✅
ProsecutionCaseDefendantUpdatedIngesterIT.shouldUpdateDefendant— passed on re-run → confirmed flaky. - ❌
ReceiveRepresentationOrderForApplicationIT.shouldRaisePublicEventWhenApplicationIsFoundForReceiveRepresentationOrderForApplicationWithOrganisation— failed again atverifyInMessagingQueueForApplication:181(Expected: is <true> but: was <false>).- Reproducible across both runs → not a random flake. Looks like a pre-existing / environmental issue with the public-event queue assertion in the local IT stack.
- Still unrelated to this PR: the change is test-only, this IT is not part of SPRDT-874: Adjournment CROWN journey updates #318, and it does not exercise the listing-needs / Crown
bookingReferencepath.
This PR's coverage
HearingToHearingListingNeedsTransformerTest— 32 tests, 0 failures, 0 errors, 0 skipped (green on both runs).
Net: the only remaining red is a deterministic, pre-existing failure outside this change's scope; worth a separate look but does not block this PR's logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See https://tools.hmcts.net/jira/browse/SPRDT-874
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist