fix: swift testing compiler mode check#353
Open
Archdoog wants to merge 1 commit intohmlongco:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Swift testing is flagged as swift 6 and 6.1, but this seems to be the compiler version because you're able to use swift testing in a Swift 5 configured project/package.
The
#if swift(>=6.1)in the originalFactoryTestingtrait meant you could use FactoryKit with a swift 5 project with swift testing. The swift tests would build fine with@Suite(.container)but the trait would never override the singleton under the@TaskLocalresulting in race conditions, missed registrations, etc.Some research lead to https://github.com/swiftlang/swift-testing/blob/66c32ae6c4f87b88c96cd6f16e6e92538177617e/Sources/Testing/Traits/Trait.swift#L57 where the availability of the trait object is noted as:
/// @Metadata { /// @Available(Swift, introduced: 6.1) /// @Available(Xcode, introduced: 16.3) /// }I've tested this on my project and it seems to work as expected.