Skip to content

Remove log that isn't providing value #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KiraNamida wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −15
Open

Remove log that isn't providing value #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions app/uk/gov/hmrc/crdlcache/schedulers/ImportCustomsOfficesListJob.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import uk.gov.hmrc.mongo.transaction.{TransactionConfiguration, Transactions}

import java.time.{Clock, LocalDate, ZoneOffset}
import javax.inject.Inject
import scala.concurrent.{ExecutionContext, Future}
import scala.concurrent.{Await, ExecutionContext, Future}
import scala.concurrent.duration.*
import java.time.Instant

Expand Down Expand Up @@ -156,18 +156,10 @@ class ImportCustomsOfficesListJob @Inject() (
def execute(
context: JobExecutionContext
): Unit =
val importFuture = withLock(importCustomsOfficeLists()).map {
_.getOrElse { logger.info("Import Customs offices job lock could not be obtained") }
}
for {
_ <- importFuture
postIngestOfficeCount <- customsOfficeListsRepository.customsOfficesCount(
Instant.now(),
domain = Some("NCTS"),
phase = Some("P6")
)
_ = logger.warn(
s"Number of NCTS P6 Customs Offices post-ingest: ${postIngestOfficeCount}"
)
} yield ()
Await.result(
withLock(importCustomsOfficeLists()).map {
_.getOrElse { logger.info("Import Customs offices job lock could not be obtained") }
},
Duration.Inf
)
}