DTR-5901 Feat-CIS Verify Batch Polling Business Function F7 - #105
Open
abhinavgupta-hmrc wants to merge 8 commits into
Open
DTR-5901 Feat-CIS Verify Batch Polling Business Function F7#105abhinavgupta-hmrc wants to merge 8 commits into
abhinavgupta-hmrc wants to merge 8 commits into
Conversation
jassalrichy
reviewed
Jul 10, 2026
jassalrichy
reviewed
Jul 10, 2026
Contributor
There was a problem hiding this comment.
Route style diverges from convention.
All other GET routes in this controller use path parameters (e.g. /cis/verification-batch/newest/:instanceId).
The new endpoint uses query parameters (?instanceId=...&verificationBatchResourceRef=...).
Contributor
Author
There was a problem hiding this comment.
Route style updated. Review comment addressed.
Contributor
Author
There was a problem hiding this comment.
Addressed.
abhinavgupta-hmrc
marked this pull request as ready for review
July 13, 2026 07:38
abhinavgupta-hmrc
requested review from
Egambaram-Panneerselvam,
sukesh90 and
yanshengzhangHMRC
July 16, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIS Verify Batch Polling Business Function F7 - Get Submission with Verification Batch