Skip to content

feat: unescape \. in path regexes #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hofbi merged 1 commit into from
Jun 8, 2026
Merged

feat: unescape \. in path regexes #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev_tools/check_useless_exclude_paths_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def extract_literal_exclude_paths(exclude_regex: str) -> list[str]:
.replace(" ", "")
.replace("(?x)^(", "")
.replace("^", "")
.replace(r"\.", ".")
.replace(")", "")
.split("|")
)
Expand Down
4 changes: 4 additions & 0 deletions tests/test_check_useless_exclude_paths_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ def test_extract_literal_exclude_paths_for_regex_only_exclude_should_return_empt
assert extract_literal_exclude_paths(r"(?x)^(bar/.*\.png|.*\.lock$)") == []


def test_extract_literal_exclude_paths_for_escaped_dot_should_unescape() -> None:
assert extract_literal_exclude_paths(r"(?x)^(foo/bar\.py)") == ["foo/bar.py"]


def test_extract_literal_exclude_paths_for_single_literal_should_return_path() -> None:
assert extract_literal_exclude_paths("packages/thirdparty/") == ["packages/thirdparty/"]

Expand Down