Add trailing commas to all generated Kotlin declarations#35
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joaoffcosta
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Kotlin now emits a trailing comma on the last element of every multi-line, comma-separated construct.
What changed
Trailing comma added to the last element of:
AnalyticsEvent,AnalyticsProperty)data classparameter listsmapOf(...)andarrayOf(...)entriesTouches the 6 Kotlin templates and the
kotlin_generatorspec fixtures.Swift output is unchanged.
Effect on consumers
Regenerating in an Android project produces only trailing-comma diffs on the generated files (verified against real sheet data).
Testing
bundle exec rspec— 67 examples, 0 failures.