Fix Singapore 2026 public holiday dates#311
Open
StephenMF-beep wants to merge 309 commits intoholidays:masterfrom
Open
Fix Singapore 2026 public holiday dates#311StephenMF-beep wants to merge 309 commits intoholidays:masterfrom
StephenMF-beep wants to merge 309 commits intoholidays:masterfrom
Conversation
add grandfinal 2020 public holiday
[PFC-1691] (fix) Add Additional Boxing Day Holiday
[PFC-1691] (fix) Add definitions for additional recognised public holidays
[PFC-1691] (fix) Add main country code :au back to ANZAC day
Fix Airbrake Unexpected Return Error Inside Lambda SA Christmas Extra Holiday Fix
[PFC-1440] (fix) Adding NT Additional Public Holiday Changes for 2020/21
…ions Update May Day in UK
Remove comma from "Martin Luther King, Jr. Day"
After 2025 use term proclamation day
This reverts commit 3af463f.
This reverts commit b80ad1f.
This reverts commit 6e23da1.
This reverts commit 004f591.
And some refactoring and fixes to the anzac day test cases.
Moves to Monday if falls on Sunday. Discovered after I googled it. Added tests out to 2035. Some refactoring of the definition file.
This function only provides the holiday on Monday if the date is on the weekend. The problem with to_monday_if_weekend is that you end up with two holidays on the same date.
Australia ANZAC Day 2026 Changes
…-2026 Australia ANZAC Day 2026 Changes
FIX |ENG-2998| Remove two unofficial Mexican bank holidays
NSW announced an additional public holiday on the Monday following ANZAC Day when it falls on a weekend, for 2026 and 2027. - 2026: Sat Apr 25 → additional holiday Mon Apr 27 - 2027: Sun Apr 25 → additional holiday Mon Apr 26 Source: https://www.nsw.gov.au/ministerial-releases/minns-labor-government-announces-extra-public-holiday-year Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add additional ANZAC Day public holiday for NSW (2026-2027)
Add special bank holiday for Scotland to observe the 2026 World Cup. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Author
|
Changed the Singapore file to have the correct dates for Deepavali 2026 date from Oct 8 to Nov 8 |
Member
|
Hello! Can you please rebase? There are a lot of unrelated changes. Then I'll review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bundle exec ruby lib/validation/run.rb— Successbundle exec rspec— 50 examples, 0 failures🤖 Generated with Claude Code