Update Friday before the AFL Grand Final public holiday#315
Merged
ppeble merged 1 commit intoholidays:masterfrom Mar 30, 2026
Merged
Update Friday before the AFL Grand Final public holiday#315ppeble merged 1 commit intoholidays:masterfrom
ppeble merged 1 commit intoholidays:masterfrom
Conversation
ppeble
approved these changes
Mar 30, 2026
Member
ppeble
left a comment
ppeble
left a comment
There was a problem hiding this comment.
Thank you! I'm attempting to get more frequent def updates, thanks for your patience. 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, welcome back @ppeble!! 🎉
Summary
afl_grand_finalmethod now defaults to last Friday in September, matching the Vic gov ruleYears where the date differs from the rule (e.g. 2020, 2022) should be overridden.