Skip to content

Add colored ticks version#88

Closed
apretto wants to merge 2 commits into
holman:masterfrom
apretto:master
Closed

Add colored ticks version#88
apretto wants to merge 2 commits into
holman:masterfrom
apretto:master

Conversation

@apretto

@apretto apretto commented Aug 14, 2015

Copy link
Copy Markdown

This PR adds a command line option "-c fire" to output the graph colored in fire (smallest tick is yellow, largest is red).

Adding additional palettes should be easy: just add a colon-separated string to the ticks_style array and a option statement for the case of the c parameter setting the correct index in the variable tick_style

@holman

holman commented Aug 14, 2015

Copy link
Copy Markdown
Owner

Do you mind dropping in a quick screenshot here?

I'm a little concerned about bloating things a little bit much (I don't think we'd need multiple color schemes, for example... maybe just a -c option), but I'm not totally 👎 on this yet either. Would be interested to hear what others think on this.

@apretto

apretto commented Aug 17, 2015

Copy link
Copy Markdown
Author

Spark with colors

@MaxWorgan

Copy link
Copy Markdown

👍 came here to see if anyone had added this

@sindresorhus

Copy link
Copy Markdown

👍 Added this to my JavaScript port.

@abrist

abrist commented Feb 24, 2017

Copy link
Copy Markdown

@apretto I was inspired by your commit and subsequently fattened up the color features in my PR: #94

@neuhaus

neuhaus commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

can we make the color range configurable (perhaps as start and end values in HSV)? I'd like it to go from green to red for example.

@abrist

abrist commented Mar 27, 2017

Copy link
Copy Markdown

@neuhaus See my PR and branch for the requested feature: #94

echo 1 2 3 4 5 6 7 8 7 6 5 4 3 2 1 | ./spark -p 52,88,160,166,172,178,148,82

screen shot 2017-03-27 at 5 01 01 pm

@apretto

apretto commented Mar 28, 2017

Copy link
Copy Markdown
Author

I'm fine with closing this PR and going with @abrist's implementation (#94).

@abrist

abrist commented Mar 29, 2017

Copy link
Copy Markdown

@apretto Thank you so much for your time, work, and inspiration!

@apretto

apretto commented Aug 14, 2018

Copy link
Copy Markdown
Author

Closing this PR finally.

@apretto apretto closed this Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants