feat: publish pre-packaged NPM package#12
Conversation
|
Warning Review limit reached
More reviews will be available in 44 minutes and 38 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR restructures the npm release workflow in a GitHub Actions job. The 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/nodejs-publish-release.yml:
- Around line 113-115: The workflow currently runs npm pack in the "Pack npm
artifact" step but does not capture the produced filename, then later uses
./*.tgz in the gh release create and npm publish steps which can pick up the
wrong tarball; update the "Pack npm artifact" step so it captures the exact
filename returned by npm pack (e.g., run npm pack and capture its stdout into a
variable) and export that filename (via step output or GITHUB_OUTPUT), then
replace all occurrences of the root glob ./*.tgz in the gh release create and
npm publish steps with the captured filename reference (the step output/env var)
so the workflow always attaches/publishes the exact tarball produced by npm
pack.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 701bc8b0-1eeb-48f5-b68e-140e425be706
📒 Files selected for processing (1)
.github/workflows/nodejs-publish-release.yml
ce4cd65 to
91415b0
Compare
|
✔️ 05673e5...91415b0 - Conventional commits check succeeded. |
Previously, all the checks passed then the release notes were extracted from the changelog and saved to a temporary file, then the NPM package was packaged which included the temporary release notes file. Then the publish command was performing the checks again as the pre-publish steps which now included the release notes which had blank lines at the beginning and end of the file.
This had a few problems:
This PR addresses points
2.and3.but the blank newlines (1.) are ignored because GitHub doesn't render them in the release notes section anyway and I don't want to over-complicate theawkcommand.