Skip to content

feat: move runtime settings link from settings homepage to settings > system#130

Merged
zippy merged 1 commit into
mainfrom
feat/move-runtime-to-system-settings-page
Sep 1, 2025
Merged

feat: move runtime settings link from settings homepage to settings > system#130
zippy merged 1 commit into
mainfrom
feat/move-runtime-to-system-settings-page

Conversation

@mattyg

@mattyg mattyg commented Aug 31, 2025

Copy link
Copy Markdown
Member

Summary

Duplicate of #129, debugging why CI is failing

TODO:

  • CHANGELOG(s) updated with appropriate info
  • docs updated (pnpm run build:doc)

Summary by CodeRabbit

  • Chores
    • Updated Android Settings integration to appear under the System category, improving organization and discoverability.
    • No impact to non-system settings builds.

@mattyg mattyg temporarily deployed to Android Service Runtime Release August 31, 2025 23:39 — with GitHub Actions Inactive
@mattyg mattyg temporarily deployed to Android Service Runtime Release August 31, 2025 23:39 — with GitHub Actions Inactive
@mattyg mattyg temporarily deployed to Android Service Runtime Release August 31, 2025 23:39 — with GitHub Actions Inactive
@cocogitto-bot

cocogitto-bot Bot commented Aug 31, 2025

Copy link
Copy Markdown

✔️ 874e47f - Conventional commits check succeeded.

@coderabbitai

coderabbitai Bot commented Aug 31, 2025

Copy link
Copy Markdown

Walkthrough

Updated the Android manifest metadata value in the Tauri build script for the system_settings feature path, changing com.android.settings.category from "com.android.settings.category.ia.homepage" to "com.android.settings.category.ia.system". No other attributes or feature paths were modified.

Changes

Cohort / File(s) Summary of Edits
Android manifest metadata update
apps/android-service-runtime/src-tauri/build.rs
In the system_settings manifest snippet, changed meta-data value of com.android.settings.category from "com.android.settings.category.ia.homepage" to "com.android.settings.category.ia.system". No other changes; the not(feature="system_settings") path is unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/move-runtime-to-system-settings-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mattyg mattyg changed the title feat: move runtime settings link from settings homepage to settings >… feat: move runtime settings link from settings homepage to settings > system Aug 31, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
apps/android-service-runtime/src-tauri/build.rs (3)

19-20: Consider a more descriptive summary string

Using the activity title as the summary may be redundant. Point the IA summary to a dedicated string (e.g., “Configure Holochain Runtime settings under System”) to improve UX.

Apply this diff here (and add the new string resource in strings.xml):

-    <meta-data android:name="com.android.settings.summary"
-            android:resource="@string/main_activity_title" />
+    <meta-data android:name="com.android.settings.summary"
+            android:resource="@string/runtime_settings_summary" />

6-6: Nit: adjust the update label for clarity

This label is shown in build logs; since this path targets System Settings only, tighten the wording.

-    "Include in App Grid or System Settings",
+    "Include in System Settings",

1-1: Follow-up: docs and changelog

PR description notes unchecked TODOs for changelogs and docs generation (pnpm run build:doc). Please complete before merge; I can help if needed.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 20a6c8f and 874e47f.

📒 Files selected for processing (1)
  • apps/android-service-runtime/src-tauri/build.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Static Analysis
  • GitHub Check: Build tauri plugins (tauri-plugin-client)
  • GitHub Check: Build apps (android-service-runtime)
  • GitHub Check: Build apps (android-service-runtime, system_settings)
  • GitHub Check: Build tauri plugins (tauri-plugin-service)
  • GitHub Check: Test Kotlin Libraries (28, x86_64, x86_64-linux-android)
  • GitHub Check: Build apps (example-client-app)
  • GitHub Check: Test Rust Crates (ubuntu-latest)
🔇 Additional comments (2)
apps/android-service-runtime/src-tauri/build.rs (2)

18-18: Category switched to 'system' — aligns with PR goal

This change correctly moves the tile from the Settings homepage to Settings > System.


15-21: Please verify OEM/API behavior for IA category

Sanity-check on at least one AOSP emulator and one OEM device (API 33+): confirm the entry appears under Settings > System and not on the homepage; also test deep-link/search behavior. Capture a quick screenshot to document.

@mattyg

mattyg commented Sep 1, 2025

Copy link
Copy Markdown
Member Author

@zippy CI is passing when I create a branch with the same changes within this repo.

I believe the reason #129 failed is because it is from a repo that is outside this github organization. Not sure if this is something that can be configured in the repo settings to allow outside branches to access secrets, or if PRs need to be made within the organization repo.

@zippy zippy merged commit 427ba4e into main Sep 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants