feat: move runtime settings link from settings homepage to settings > system#130
Conversation
|
✔️ 874e47f - Conventional commits check succeeded. |
WalkthroughUpdated the Android manifest metadata value in the Tauri build script for the system_settings feature path, changing com.android.settings.category from "com.android.settings.category.ia.homepage" to "com.android.settings.category.ia.system". No other attributes or feature paths were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/android-service-runtime/src-tauri/build.rs (3)
19-20: Consider a more descriptive summary stringUsing the activity title as the summary may be redundant. Point the IA summary to a dedicated string (e.g., “Configure Holochain Runtime settings under System”) to improve UX.
Apply this diff here (and add the new string resource in strings.xml):
- <meta-data android:name="com.android.settings.summary" - android:resource="@string/main_activity_title" /> + <meta-data android:name="com.android.settings.summary" + android:resource="@string/runtime_settings_summary" />
6-6: Nit: adjust the update label for clarityThis label is shown in build logs; since this path targets System Settings only, tighten the wording.
- "Include in App Grid or System Settings", + "Include in System Settings",
1-1: Follow-up: docs and changelogPR description notes unchecked TODOs for changelogs and docs generation (
pnpm run build:doc). Please complete before merge; I can help if needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/android-service-runtime/src-tauri/build.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Static Analysis
- GitHub Check: Build tauri plugins (tauri-plugin-client)
- GitHub Check: Build apps (android-service-runtime)
- GitHub Check: Build apps (android-service-runtime, system_settings)
- GitHub Check: Build tauri plugins (tauri-plugin-service)
- GitHub Check: Test Kotlin Libraries (28, x86_64, x86_64-linux-android)
- GitHub Check: Build apps (example-client-app)
- GitHub Check: Test Rust Crates (ubuntu-latest)
🔇 Additional comments (2)
apps/android-service-runtime/src-tauri/build.rs (2)
18-18: Category switched to 'system' — aligns with PR goalThis change correctly moves the tile from the Settings homepage to Settings > System.
15-21: Please verify OEM/API behavior for IA categorySanity-check on at least one AOSP emulator and one OEM device (API 33+): confirm the entry appears under Settings > System and not on the homepage; also test deep-link/search behavior. Capture a quick screenshot to document.
|
@zippy CI is passing when I create a branch with the same changes within this repo. I believe the reason #129 failed is because it is from a repo that is outside this github organization. Not sure if this is something that can be configured in the repo settings to allow outside branches to access secrets, or if PRs need to be made within the organization repo. |
Summary
Duplicate of #129, debugging why CI is failing
TODO:
pnpm run build:doc)Summary by CodeRabbit