Chore/v0.1.5#133
Conversation
…bumping hc version
|
❌ Found 6 compliant commit and 1 non-compliant commits in bd0786b...8f4bf8d. Commit c5ef414 by @zippy is not conform to the conventional commit specification :
|
WalkthroughThis PR performs a coordinated release preparation across multiple crates and configurations. It bumps holochain workspace dependencies from 0.5.4 to 0.5.6, increments various crate versions from 0.2.1 to 0.2.2, updates android-service-runtime from 0.1.1 to 0.1.5, updates network configuration URLs for bootstrap/signal endpoints, bumps Android gradle dependencies, and updates release documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The changes follow a consistent, repetitive pattern across files (version bumps in manifests and configuration). While affecting 20+ files across multiple file types (Rust manifests, Kotlin gradle, JSON, Markdown), each individual change is straightforward with low complexity. The network URL configuration updates are simple value replacements. The documentation changes involve restructuring release procedures without functional code impact. Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockflake.lockis excluded by!**/*.lock
📒 Files selected for processing (19)
CHANGELOG.md(1 hunks)Cargo.toml(1 hunks)DEVELOPMENT.md(3 hunks)apps/android-service-runtime/package.json(1 hunks)apps/android-service-runtime/src-tauri/Cargo.toml(1 hunks)apps/android-service-runtime/src-tauri/src/lib.rs(1 hunks)apps/android-service-runtime/src-tauri/tauri.conf.json(1 hunks)apps/example-client-app/Cargo.toml(1 hunks)crates/runtime-ffi/Cargo.toml(1 hunks)crates/runtime-types-ffi/Cargo.toml(1 hunks)crates/runtime/Cargo.toml(1 hunks)crates/tauri-plugin-client/Cargo.toml(2 hunks)crates/tauri-plugin-client/android/build.gradle.kts(1 hunks)crates/tauri-plugin-service/Cargo.toml(2 hunks)crates/tauri-plugin-service/android/build.gradle.kts(1 hunks)libraries/client/README.md(1 hunks)libraries/client/build.gradle.kts(1 hunks)libraries/service/README.md(1 hunks)libraries/service/build.gradle.kts(2 hunks)
🧰 Additional context used
🪛 LanguageTool
DEVELOPMENT.md
[uncategorized] ~63-~63: The official name of this software platform is spelled with a capital “H”.
Context: ...them to the draft release. 4. Visit the github releases page, and publish the draft re...
(GITHUB)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Static Analysis
- GitHub Check: Test Kotlin Libraries (28, x86_64, x86_64-linux-android)
- GitHub Check: Build apps (android-service-runtime, system_settings)
- GitHub Check: Build apps (example-client-app)
- GitHub Check: Build apps (android-service-runtime)
- GitHub Check: Build tauri plugins (tauri-plugin-service)
- GitHub Check: Build tauri plugins (tauri-plugin-client)
- GitHub Check: Test Rust Crates (ubuntu-latest)
🔇 Additional comments (19)
libraries/client/README.md (1)
26-26: Verify version consistency with build.gradle.kts.The README now documents version 0.0.19. Ensure this matches the
coordinatesversion inlibraries/client/build.gradle.kts.libraries/service/README.md (1)
26-26: Verify version consistency with build.gradle.kts.The README now documents version 0.0.19. Ensure this matches the
coordinatesversion inlibraries/service/build.gradle.kts.apps/android-service-runtime/package.json (1)
4-4: Verify version consistency across android-service-runtime manifests.The package.json version is now 0.1.5. Ensure this matches
apps/android-service-runtime/src-tauri/Cargo.tomlandapps/android-service-runtime/src-tauri/tauri.conf.json.crates/runtime-types-ffi/Cargo.toml (1)
3-3: LGTM.The version bump to 0.2.2 aligns with the coordinated release. Ensure consistency with
crates/runtime/Cargo.tomlandcrates/runtime-ffi/Cargo.toml.libraries/client/build.gradle.kts (1)
51-51: Client coordinates version verified and consistent.The client coordinates version 0.0.19 in build.gradle.kts matches the version documented in README.md. No discrepancies found.
libraries/service/build.gradle.kts (1)
51-51: Verified: coordinates match README documentation.The service coordinates (0.0.19) in
build.gradle.ktsand the version documented inREADME.mdare consistent. No issues found.crates/runtime-ffi/Cargo.toml (1)
3-3: Version consistency verified across all runtime crates.All runtime crates (runtime, runtime-ffi, runtime-types-ffi) are at 0.2.2, and dependent crates (tauri-plugin-service, tauri-plugin-client) have their dependencies correctly updated to version 0.2.2. The version bump is consistent and complete.
apps/android-service-runtime/src-tauri/tauri.conf.json (1)
3-3: Version consistency verified across all android-service-runtime manifests.All three files have been confirmed at version 0.1.5:
package.json: 0.1.5 ✓tauri.conf.json: 0.1.5 ✓src-tauri/Cargo.toml: 0.1.5 ✓The version bump is properly synchronized with no inconsistencies.
crates/tauri-plugin-service/Cargo.toml (1)
3-3: LGTM! Version bump coordinated with dependency.The package version and dependency on
holochain-conductor-runtime-types-ffiare both updated to 0.2.2 in alignment with the broader workspace release.Also applies to: 17-17
Cargo.toml (1)
24-26: Holochain dependency bump from 0.5.4 to 0.5.6.The workspace-level holochain dependencies are being updated across a minor version. Ensure that integration tests have been run to verify compatibility with the new holochain version, especially given the FFI/conductor interactions in this project.
CHANGELOG.md (2)
1-4: Clarify Unreleased section content.The Unreleased section contains a specific feature description that appears complete. Should this entry be moved into the 0.2.2 release notes, or does it represent future work that hasn't been released yet? If it's part of this release, consolidate it into the 0.2.2 section.
5-9: CHANGELOG updated for 0.2.2 release.The CHANGELOG entry accurately reflects the key changes in this PR, including the holochain bump to 0.5.6 and the bootstrap URL fix.
Note: The PR is titled "Chore/v0.1.5" but the CHANGELOG shows version 0.2.2. This is expected since multiple versioned artifacts exist in this monorepo (android-service-runtime at 0.1.5, runtime crates at 0.2.2), but it may cause confusion.
crates/runtime/Cargo.toml (1)
3-3: LGTM! Version bump to 0.2.2.The runtime crate version is updated in alignment with the coordinated workspace release.
apps/example-client-app/Cargo.toml (1)
12-13: LGTM! HDI/HDK version bumps.The example client app dependencies are updated to align with the holochain 0.5.6 upgrade in the workspace.
apps/android-service-runtime/src-tauri/Cargo.toml (1)
3-3: Version updated to 0.1.5.The android-service-runtime version jumps from 0.1.1 to 0.1.5, which aligns with the PR title. This significant jump suggests bundled changes or version alignment with other artifacts in the monorepo.
crates/tauri-plugin-client/Cargo.toml (1)
3-3: LGTM! Version bump coordinated with dependency.The package version and dependency on
holochain-conductor-runtime-types-ffiare both updated to 0.2.2, consistent with the workspace-wide release.Also applies to: 14-14
apps/android-service-runtime/src-tauri/src/lib.rs (1)
19-21: I need to verify the legitimacy and configuration of these infrastructure endpoints through web research. The HTTP 404 responses are inconclusive since these may use different protocols or services.Based on my verification, I need to refine the review comment. The search results show that:
Volla is a legitimate German startup (Hallo Welt Systeme UG) that integrates Holochain, and Relay is Volla's encrypted messaging service using Holochain.
Regarding the STUN server on port 443: This is actually a legitimate configuration, not uncommon. When clients are behind restrictive firewalls allowing only port 443, a TURN/STUN server can be configured on port 443 for compatibility. Running STUN/TURN on port 443 TCP avoids many firewall issues compared to standard ports.
While most public STUN servers use ports 3478 or 19302, the configuration here is intentionally using port 443 for firewall traversal.
The HTTP 404 responses in the script are inconclusive since STUN servers use a specialized protocol, not HTTP.
Verify infrastructure endpoints are operational and stable for production use.
The network configuration updates use legitimate services:
- Relay is Volla's encrypted messaging service, confirming relay.volla.tech is a known infrastructure provider.
- stun.nextcloud.com:443 is a valid configuration for clients behind restrictive firewalls with only port 443 access.
However, manually test the actual endpoints with STUN/WebRTC-specific tools rather than HTTP, and consider whether these URLs should be configurable for different deployment environments (dev/staging/production).
crates/tauri-plugin-client/android/build.gradle.kts (1)
50-50: Version bump is consistent across all gradle.kts files.Verification confirms all holochain androidserviceruntime dependencies across the codebase have been updated to version 0.0.19:
crates/tauri-plugin-client/android/build.gradle.kts:50→client:0.0.19crates/tauri-plugin-service/android/build.gradle.kts:62-63→service:0.0.19andclient:0.0.19libraries/service/build.gradle.kts:82→client:0.0.19libraries/client/build.gradle.kts→ versioned via coordinates to0.0.19The coordinated bump is correct and no missed updates remain.
crates/tauri-plugin-service/android/build.gradle.kts (1)
62-63: All androidserviceruntime versions are properly synchronized at 0.0.19 across gradle files.Verification confirms that the version updates are consistent and aligned:
- Both
crates/tauri-plugin-service/android/build.gradle.ktslines 62–63 are at 0.0.19 (service and client) ✓crates/tauri-plugin-client/android/build.gradle.ktsline 50 is at 0.0.19 (client) ✓libraries/service/build.gradle.ktslines 51 and 82 are at 0.0.19 (service and client) ✓- All androidserviceruntime FFI/conductor library versions match across the codebase
The version alignment is correct, with service and client libraries synchronized. No breaking version mismatches detected.
| ## Publishing tauri-plugin-service crate releases | ||
| 3. Wait for the release CI to complete. It will create a draft release, build both apps, and upload them to the draft release. | ||
| 4. Visit the github releases page, and publish the draft release. |
There was a problem hiding this comment.
Capitalize "GitHub" per standard naming conventions.
Per static analysis: "The official name of this software platform is spelled with a capital H."
-4. Visit the github releases page, and publish the draft release.
+4. Visit the GitHub releases page, and publish the draft release.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 4. Visit the github releases page, and publish the draft release. | |
| 4. Visit the GitHub releases page, and publish the draft release. |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~63-~63: The official name of this software platform is spelled with a capital “H”.
Context: ...them to the draft release. 4. Visit the github releases page, and publish the draft re...
(GITHUB)
🤖 Prompt for AI Agents
In DEVELOPMENT.md around line 63, the text uses a lowercase "github"; update
that word to the correct "GitHub" capitalization on the line "Visit the github
releases page, and publish the draft release." to comply with naming conventions
and static analysis; ensure only the word is changed and punctuation/spacing
remains unchanged.
Summary
Making new build for v0.1.5 that solves the open settings issue
TODO:
pnpm run build:doc)