Merged
Conversation
bump version to v2025.11-01
There was a problem hiding this comment.
Pull request overview
This PR updates the package to comply with GAP 4.15.1 requirements by modernizing the global variable declaration pattern and bumping the version to 2025.11-01. The changes include both code updates and corresponding test output adjustments.
- Replaced
InstallValuewithDeclareGlobalVariablepattern with the modernBindGlobalapproach forSkeletalSmoothMaps - Updated minimum GAP version requirement from 4.13.0 to 4.15.1
- Updated test expectations to reflect improved formatting (removal of redundant parentheses in expression output)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| PackageInfo.g | Updated version to 2025.11-01 and minimum GAP requirement to 4.15.1 |
| gap/CategoryOfSkeletalSmoothMaps.gd | Removed DeclareGlobalVariable declaration for SkeletalSmoothMaps |
| gap/CategoryOfSkeletalSmoothMaps.gi | Changed from InstallValue to BindGlobal for SkeletalSmoothMaps definition |
| tst/example-in-readme-1.tst | Removed blank line in test output |
| tst/example-in-readme-2.tst | Updated test expectations to match improved expression formatting (fewer parentheses) |
| examples/Expressions.g | Updated expected output comments to match improved expression formatting |
| examples/CategoryOfSkeletalSmoothMaps.g | Updated expected output comments to match improved expression formatting |
| examples/CategoryOfLenses.g | Updated expected output comments to match improved expression formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump version to v2025.11-01