Background animation gradient fixes

[honghaoz]

Summary by CodeRabbit

• Bug Fixes
  • Improved background gradient animations across gradients with differing numbers of color stops by padding interpolation data to prevent visible jumps.
  • When transitioning between mismatched gradient types, animations are skipped and the new background is applied immediately for more predictable behavior.
  • Retargeting during an in-progress gradient animation now properly stops the current animation and applies the new gradient state.
• Documentation
  • Updated documentation guidelines for consistent wrapping and Apple-style section coverage.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f12cc91d-7fb5-46a7-8483-c020deab8594

📥 Commits

Reviewing files that changed from the base of the PR and between 5bf4689 and 27e544c.

📒 Files selected for processing (2)

• ChouTiUI/Sources/ChouTiUI/Universal/CoreAnimation/CALayer+BackgroundColor.swift
• ChouTiUI/Tests/ChouTiUITests/Universal/CoreAnimation/CALayer+BackgroundColorTests.swift

---

📝 Walkthrough

Walkthrough

Gradient background animations now skip incompatible gradient types, pad differing stop arrays for interpolation, and apply expanded tests. Documentation guidance also covers line wrapping and Apple-style parameter, return, and throws sections.

Changes

Gradient animation handling

Layer / File(s)	Summary
Gradient animation behavior ChouTiUI/Sources/ChouTiUI/Universal/CoreAnimation/CALayer+BackgroundColor.swift, AGENTS.md	Mismatched gradient types now bypass animation and update immediately; matching gradients pad colors and locations to a shared count. Documentation rules define wrapping and Apple-style declaration details.
Gradient animation validation ChouTiUI/Tests/ChouTiUITests/Universal/CoreAnimation/CALayer+BackgroundColorTests.swift	Tests verify interpolation values, immediate updates, and animation-layer cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the main theme of the changes: fixes to background gradient animation behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch background-animation-gradient-fixes

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.87%. Comparing base (4e31aa8) to head (27e544c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   95.77%   95.87%   +0.09%     
==========================================
  Files         120      120              
  Lines        4855     4873      +18     
==========================================
+ Hits         4650     4672      +22     
+ Misses        205      201       -4     

Flag	Coverage Δ
ChouTiUI	95.87% <100.00%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...versal/CoreAnimation/CALayer+BackgroundColor.swift	97.72% <100.00%> (+0.16%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ChouTiUI/Sources/ChouTiUI/Universal/CoreAnimation/CALayer`+BackgroundColor.swift:
- Around line 339-343: In the gradient-type mismatch branch within the
background animation flow, call tearDownAnimationGradientLayer() before break so
any active animation overlay is removed immediately and the new background can
apply. Add a regression test covering retargeting an in-progress gradient
animation from one layer type to the other.

In
`@ChouTiUI/Tests/ChouTiUITests/Universal/CoreAnimation/CALayer`+BackgroundColorTests.swift:
- Around line 789-844: In test_animation_gradientToGradient_differentColorCounts
and the nearby mismatched-gradient animation test, replace all repeated 0.05
animation duration literals with a named private test constant, grouped in the
existing or a new Constants type as appropriate. Use that constant for each
.easeInEaseOut duration so the timing intent is centralized.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 418137e5-201f-4c60-a75c-e37944553e2b

📥 Commits

Reviewing files that changed from the base of the PR and between 4e31aa8 and 5bf4689.

📒 Files selected for processing (3)

• AGENTS.md
• ChouTiUI/Sources/ChouTiUI/Universal/CoreAnimation/CALayer+BackgroundColor.swift
• ChouTiUI/Tests/ChouTiUITests/Universal/CoreAnimation/CALayer+BackgroundColorTests.swift

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5bf4689211

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[honghaoz]

@cursoragent review the code

[honghaoz]

@cursoragent are you there?