Open
Conversation
ca48432 epee: only parse valid port (selsta)
a5b2ad0 BlockchainLMDB: do not assume alignment for alt block entries (jeffro256)
a764f5a ci: macos: reinstall cmake (tobtoht)
Fix four issues with wallet_keys_unlocker: 1. It won't decrypt if there are unlockers open simulataneously on multiple `wallet2` instances 2. It won't decrypt if the first unlocker was disabled (i.e. `locked=false`), even with a second non-disabled unlocker 3. If a destructor of an earlier unlocker is triggered before the destructor of a later unlocker, it will re-encrypt too early, while the second unlocker is still in scope 4. Calling the 3-parameter constructor with `locked=true` after an unlocker already exists will "double-encrypt" the spend key after its destructor since the local variable is `locked=false` and the field member is `locked=true` Also, replace `wallet2::decrypt_account_for_multisig` with `wallet_keys_unlocker`.
dbc8402 wallet: fix wallet_keys_unlocker (jeffro256)
0b1b9f7 CMake: fix msys/ICU compilation failure (0xFFFC0000)
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Add macro definition for fuzzers Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Fix FuzzedDataProvider header missing problem Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Add README Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Provide static FuzzedDataProvider.h Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Update and enhance fuzzer Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Activate UBSan Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Fix fuzz target retrieval Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Remove bias selector and fix protocol lifespan Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Drop SIGALARM handling and fix bug on selectors Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Fix rpc request changes Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Add a new fuzzer profile that catch all expcetions Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Fix typo Signed-off-by: Arthur Chan <arthur.chan@adalogics.com> Add warning Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
36bdfad rpc-fuzz: Add new fuzzers for RPC endpoints (Arthur Chan)
- Make sure to mark identified spends in the pool as spends. The wallet might not know these have been spent if it wasn't the wallet that relayed the tx to the daemon, or the wallet was cleared via rescan_bc. - Make sure to add spends to m_unconfirmed_txs if not present. - Make sure to process the entire pool again if refreshing for the first time. The wallet fetches pool and blocks at the same time. The wallet scans blocks first, then pool. If the wallet identifies received outputs in the chain, then it may have spent those received outputs in the pool. So we make sure to re-process the entire pool again after scanning the chain for the first time. - Multisig wallets that know about spent key images can now detect spend txs in the pool. Update tests for that.
A reorg can end up causing an output's position in the chain to move. Since the wallet doesn't update the RingDB on reorg, it may refer to the output's stale position in the chain. This seems a reasonable solution rather than introducing complex logic to update the stale ring member's value on rerog, since RingDB can be deprecated with FCMP++.
remove 66.85.74.134 as seed node. bastards doubled the price of the server.
Bug was introduced in c069c04, before this txpool additions were not notified on block addition When receiving blocks with previously unknown conditions, miner data was sent first, but txpool add events for already-added transactions in previous block were sent afterward. Miners would then include already-mined transactions in their new templates due to receiving the mistimed txpool add event. The fix is to send miner notifications AFTER txpool events are sent, and before normal block notifications are sent (for mining switch speed purposes) Fixes c069c04 / #9135 Fixes dfee15e / #7891
5860b43 tests: only enable fuzz testing if ENABLE_FUZZ_TEST defined (0xFFFC0000)
935f2d2 cryptonote_core: `--dns-versions-check` is deprecated (nahuhh)
92c8bd5 remove 66.85.74.134 as seed node (Gingeropolous)
dc759e8 minimal changes to remove improper binding to temporary variable (dabbonda)
b74ca72 cmake: set minimum to 3.10 to fix warnings (selsta)
179c924 Fix logging lock, future optimizations may needed (Lee *!* Clagett)
…ntage 'spy nodes'
88ef30b ci: arch: add missing boost-libs dependency (tobtoht)
0bc4c23 fix: add missing <type_traits> include for std::is_same (Ocheretovich)
8877526 crypto: fix chacha aliasing and alignment issues (jeffro256)
1c97b0d abstract_tcp_server2: add missing return (selsta)
c5be4dd crypto: STD-compliant shifting in sc_check() (jeffro256)
af765a2 brew: remove unnecessary homebrew/bundle tap (ratchips)
9c3bef0 ci: depends: bump container to ubuntu 22.04 (tobtoht)
b93bba4 ci: bump deprecated actions (tobtoht)
1498737 zmq: add restricted rpc mode (selsta)
Co-authored-by: plowsof <77655812+plowsof@users.noreply.github.com>
d3efb8f guix: bump time-machine to 4a507aa8c0a579d150267d81ab4013189a7ec505 (tobtoht)
3e2c837 Cleanup some of the fragmented levin handling (Lee *!* Clagett)
76405af ci: build: bump ubuntu containers (tobtoht)
c805626 depends: extract cached package as self (tobtoht)
742c629 p2p: fix hanging shutdown (j-berman)
bc5cdf4 wallet: unrestrict `get_transfers` and `get_transfer_by_txid` (jeffro256)
08c9aec multisig: add flag to skip refresh after multisig import (woodser)
b19cd82 wallet2: fix background wallet detection in verify_password() (selsta)
604bb05 fix: return early in sensitive methods for --restricted-rpc (SNeedlewoods)
9ed9102 Correct help messages' default number of daemon out peers (S5NC)
3aa793f rpc: restrict `add_aux_pow` (hinto.janai)
50b259d p2p: isolate regtest from mainnet bootstrap state (Jeetraj)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.