refactor: pagination helpers & improve logstore test suite #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
alexbouchardd
approved these changes
Jan 19, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract tests from drivertest.go into focused files: - operations.go: CRUD tests (insert, list, retrieve) - pagination.go: cursor-based pagination tests using paginationtest.Suite - misc.go: isolation, edge cases, and cursor validation tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace separate test functions with a single testCRUD that: - Seeds data once, then tests insert verification, list filters, and retrieve - Groups related assertions together (insert→list→retrieve flow) - Renames "Operations" to "CRUD" for clarity Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Verifies that racing N goroutines inserting the same DeliveryEvent results in exactly 1 record, ensuring idempotency under concurrent load. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove ErrInvalidCursor from internal/logstore/driver - Remove convertCursorError helper from all logstore implementations - Return cursor.ErrInvalidCursor directly from Decode callbacks - Update drivertest to check for cursor.ErrInvalidCursor The cursor package already defines ErrInvalidCursor and ErrVersionMismatch, so the driver package doesn't need its own duplicate error type. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, invalid cursor errors would return 500 Internal Server Error. Now properly returns 400 Bad Request for cursor.ErrInvalidCursor and cursor.ErrVersionMismatch, consistent with tenant_handlers.go behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.