refactor: api response schema #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add gt, lt operators to date filter (in addition to gte, lte) - Add any operator for date, string, and number filters - Add contains operator for string filters - Add number filter with all comparison operators - Add array param parser for bracket notation (item[0]=a&item[1]=b) - Remove defaults from ParseDir and ParseOrderBy (store handles defaults) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove gt, lt, any, contains operators (stores don't support yet) - Return 400 for unsupported operators with clear message - Remove string and number filter helpers (not needed yet) - Keep array param parser for future use Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ListTenant does not support date filtering - only basic pagination with dir parameter. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Rename list responses to {Entity}PaginatedResult pattern
- Rename PaginationInfo to SeekPagination
- Update query params: dir, order_by, bracket notation dates
- Add APIErrorResponse and EventPaginatedResult schemas
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update list response assertions: data -> models - Update pagination cursor access: body["next"] -> body["pagination"]["next"] - Update date filter tests: start= -> event_time[gte]= - Update sort order tests: sort_order= -> dir= - Update validation error assertions: map format -> array format - Legacy endpoint tests unchanged (backward compatibility) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive tests for cursor-based pagination combined with time filters (GTE/LTE/GT/LT): - drivertest/pagination.go: TimeFilterWithCursor test suite covering paginating within time windows, boundary exclusion with GT/LT, backward pagination, and both events and deliveries - e2e/log_test.go: API-level test for cursor + time filter interaction using explicit event timestamps for deterministic ordering - pagination.go: Update parseDateTime to try RFC3339Nano first to handle millisecond precision timestamps Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Jan 19, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously expanded to availableTopics list, now returns ["*"] directly.
Show example timestamps in the validation error to make it clearer that millisecond precision (RFC3339Nano) is also supported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data→models, move pagination to nestedpaginationobjectsort_order→dir, date filters use bracket notation (event_time[gte]=)