-
Notifications
You must be signed in to change notification settings - Fork 7
3.0.1 #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.1 #709
Changes from all commits
f68e0b9
4f7c145
ebe4df5
cfe60a0
3684fa1
e0b51d9
f69aa4e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1 +1 @@ | ||||||
| "@hoprnet:registry" "https://europe-west3-npm.pkg.dev/hoprassociation/npm/" | ||||||
| //"@hoprnet:registry" "https://europe-west3-npm.pkg.dev/hoprassociation/npm/" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Commenting out the private registry can break Release installs. Build workflow uses a custom action that likely injects registry config, but release.yaml uses a different action; yarn build there may fail resolving @hoprnet/* prereleases. Two ways to fix: Option A — re-enable registry here: -//"@hoprnet:registry" "https://europe-west3-npm.pkg.dev/hoprassociation/npm/"
+"@hoprnet:registry" "https://europe-west3-npm.pkg.dev/hoprassociation/npm/"Option B — keep this commented and switch Release to the private-registry setup action (preferred for env consistency). See suggested diff in release.yaml comment. 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release job likely missing private registry setup.
Since .yarnrc disables the registry, yarn build here may not resolve @hoprnet/* packages. Use the same private-registry action as CI.
📝 Committable suggestion
🤖 Prompt for AI Agents