Skip to content

update sdk to show faulty rpc#712

Merged
mjadach-iv merged 1 commit intomainfrom
faulty-rpc-show
Sep 18, 2025
Merged

update sdk to show faulty rpc#712
mjadach-iv merged 1 commit intomainfrom
faulty-rpc-show

Conversation

@mjadach-iv
Copy link
Contributor

@mjadach-iv mjadach-iv commented Sep 18, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Resolved an issue where the corrupted channel list could fail to populate or display incorrectly, improving reliability of channel status reporting.
  • Chores

    • Updated @hoprnet/hopr-sdk to the latest pre-release version to stay current with upstream improvements.

@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates @hoprnet/hopr-sdk version in package.json. Adjusts getChannelsCorruptedThunk.fulfilled handler to read corrupted channel IDs from action.payload?.channelIds with a [] fallback, reflecting a payload shape change. No other logic or exported signatures changed.

Changes

Cohort / File(s) Summary
Dependency version bump
package.json
Bumped @hoprnet/hopr-sdk from 3.0.3-pr.156-20250916114518 to 3.0.3-pr.156-20250918200326.
Redux thunk payload handling
src/store/slices/node/actionsAsync.ts
In getChannelsCorruptedThunk.fulfilled, derive corruptedChannelIds from action.payload?.channelIds ?? [] instead of treating action.payload as an array.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as UI
  participant Store as Redux Store
  participant Thunk as getChannelsCorruptedThunk
  participant API as Backend
  participant Reducer as node/actionsAsync.fulfilled

  UI->>Store: dispatch(getChannelsCorruptedThunk)
  Store->>Thunk: Execute thunk
  Thunk->>API: Request corrupted channels
  API-->>Thunk: { channelIds: string[] }
  Thunk-->>Store: fulfill(action.payload)
  Store->>Reducer: fulfilled(action)
  note right of Reducer: Now reads action.payload?.channelIds ?? []
  Reducer-->>Store: Update state (isFetching=false, set corrupted IDs)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • V3.0.0 #702: Adjusts the same fulfilled handler to consume payload with channelIds, aligning payload shape.
  • Update HOPRd SDK to latest #710: Further modification of getChannelsCorruptedThunk.fulfilled to refine derivation of corrupted channel IDs from the payload.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch faulty-rpc-show

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e97eda and e044b65.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/store/slices/node/actionsAsync.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mjadach-iv mjadach-iv merged commit df44691 into main Sep 18, 2025
2 of 3 checks passed
@mjadach-iv mjadach-iv deleted the faulty-rpc-show branch September 18, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant