Improved general usage and added CMake integration#1
Open
Pseudomanifold wants to merge 11 commits intohoracepan:masterfrom
Open
Improved general usage and added CMake integration#1Pseudomanifold wants to merge 11 commits intohoracepan:masterfrom
Pseudomanifold wants to merge 11 commits intohoracepan:masterfrom
Conversation
Currently, the main function contains a hard-coded list of data sets and their unique labels. It is easier to determine this automatically. Plus, the use of `PTC` in the code is misleading, because it comes in multiple versions.
The project can now be built as described in the manual. C++11 is automatically selected, but no optimisation flags are set yet. If this is required, the setup has to be adjusted.
Owner
|
Hi @Pseudomanifold, |
Author
|
Dear Horace, Take your time! I merely wanted to 'push' my changes lest I forget about them in some forlorn repository. There's definitely no rush! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear authors,
I improved the general usage of the
runMLGapplication by implementing proper loading and processing for arbitrary data sets. Moreover, I added genericCMakeintegration such that building the tool should now be easier.Hope you like this pull request; let me know if I can improve it in any way. Thank you very much for providing your code in the first place, I really appreciate it!