Conversation
RashRAJ
requested review from
Techebraheem,
Timtech4u,
brightballo and
m3rryqold
and removed request for
m3rryqold
m3rryqold
approved these changes
Feb 24, 2023
m3rryqold
left a comment
m3rryqold
left a comment
There was a problem hiding this comment.
@RashRAJ
This looks good to go. I would also suggest reusing some standard modules from https://registry.terraform.io/namespaces/terraform-aws-modules.
This may be useful:
https://developer.hashicorp.com/terraform/language/modules/develop#module-structure
Timtech4u
reviewed
Feb 26, 2023
Comment on lines
+1
to
+5
| provider "aws" { | ||
| access_key = "${var.access_key}" | ||
| secret_key = "${var.secret_key}" | ||
| region = "${var.region}" | ||
| } |
Contributor
Timtech4u
requested changes
Feb 26, 2023
Contributor
Timtech4u
left a comment
Timtech4u
left a comment
There was a problem hiding this comment.
@RashRAJ I tried using this module in my PR but it fails cause of the spaces.
It'll be good to not have spaces in Terraform modules.
Failing action: https://github.com/hostspaceng/Terraform/actions/runs/4275537866/jobs/7442962431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the instance, load balancer and security group module